Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Mirror integration which adds syntax highlighting, theming, line nu... #5

Merged
merged 1 commit into from Mar 14, 2012

Conversation

hamin
Copy link
Contributor

@hamin hamin commented Mar 14, 2012

...mbers & tab spacing

This addresses the line number TODO item and then some! Codemirror is pretty awesome and lightweight compared to the others http://codemirror.net/ . I can add some more codemirror integration (such as code folding & vim bindings) if you like what I've done so far.

I've included the rubyblue theme, but really you can write your own theme if you want or adjust the current one. I couldn't find a default railscasts theme :)

@jwo
Copy link
Owner

jwo commented Mar 14, 2012

@hamin this looks fantastic. Fan freaking tastic. Many thanks!

I'm not a code folding fan, so probably leave that off (unless others ask). I know I'd love the Vim bindings, but others might not. What's your thoughts on having that be something we can turn on/off on the screen?

(Keeping Pull open for conversation -- once we decide, I'll pull and merge). love this.

@hamin
Copy link
Contributor Author

hamin commented Mar 14, 2012

@jwo glad you liked it man :) It could use some styling love but I will leave it to you :)

Will leave code folding off for now then. As far as the bindings go, I actually use vim occasionally (sitll love Textmate and nano ;) ). But vim and emacs keybindgins are available and I should be able to integrate them fairly easily. We can definitely make them optional and turned off by default. I'm thinking something like a segmented control with the options None, Vim, Emacs http://forrst.com/posts/Cocoa_like_segmented_control_in_pure_CSS3-uH3

What do u think? Also do u want the key bindings in this pull request or another?

@jwo
Copy link
Owner

jwo commented Mar 14, 2012

Let's do the emacs/vim with the button group like you linked to, in a
separate request.

I'll pull this in and style the colors a bit.

  • jesse

On Mar 13, 2012, at 11:24 PM, Haris Amin
reply@reply.github.com
wrote:

@jwo glad you liked it man :) It could use some styling love but I will leave it to you :)

Will leave code folding off for now then. As far as the bindings go, I actually use vim occasionally (sitll love Textmate and nano ;) ). But vim and emacs keybindgins are available and I should be able to integrate them fairly easily. We can definitely make them optional and turned off by default. I'm thinking something like a segmented control with the options None, Vim, Emacs http://forrst.com/posts/Cocoa_like_segmented_control_in_pure_CSS3-uH3

What do u think? Also do u want the key bindings in this pull request or another?


Reply to this email directly or view it on GitHub:
#5 (comment)

@hamin
Copy link
Contributor Author

hamin commented Mar 14, 2012

@jwo sounds good :)

@jwo jwo merged commit f9226f9 into jwo:master Mar 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants