Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue initalising PhysMember #183

Closed
linokl opened this issue Feb 11, 2024 · 3 comments
Closed

Issue initalising PhysMember #183

linokl opened this issue Feb 11, 2024 · 3 comments

Comments

@linokl
Copy link

linokl commented Feb 11, 2024

Hi Craig

I think there is a bug due to a mismatch in variable positions in the initialisation call for PhysMember

In PhysMember, when you initialise the member the super init is called with "model" variable in 10th position

image

In Member3D, in the initialisation function, "model" variable is in 6th position

image

When I am initialising the PhysMember i get an error after updating the pynite to the latest version. Possibly due to this issue I think

Regards
Lino

@JWock82
Copy link
Owner

JWock82 commented Feb 19, 2024

That's strange. All my unit tests are passing. I'll look into this a bit closer. I just changed it, and all my unit tests failed.

@JWock82
Copy link
Owner

JWock82 commented Feb 21, 2024

I've corrected the code to be consistent across both classes. Newest version is v0.0.88 now.

@JWock82 JWock82 closed this as completed Feb 21, 2024
@linokl
Copy link
Author

linokl commented Feb 23, 2024

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants