Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0 rewrite #9

Merged
merged 17 commits into from
Oct 12, 2023
Merged

v1.0 rewrite #9

merged 17 commits into from
Oct 12, 2023

Conversation

jwodder
Copy link
Owner

@jwodder jwodder commented Oct 11, 2023

Closes #8.

To do:

  • Remove move_first
  • Remove delay_open and open()
  • When the input path points to a symlink and backup_ext is given, append the backup extension to the resolved path rather than to the pre-resolved path.
  • Remove readall()
  • Drop support for Python 3.7
  • Remove InPlaceText and InPlaceBytes
  • Split InPlace into text-only InPlace and bytes-only InPlaceBytes (no mode argument)
  • Add type annotations (Closes Mypy type compliance #6)
  • Give InPlace binary read1() and readinto1() methods
  • Clean up/improve tests

@jwodder jwodder added enhancement New feature or request therefor breaking change Introduction of an incompatible API change labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #9 (5c47411) into master (da88595) will increase coverage by 1.96%.
The diff coverage is 94.96%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   93.00%   94.96%   +1.96%     
==========================================
  Files           1        1              
  Lines         200      159      -41     
  Branches       39       18      -21     
==========================================
- Hits          186      151      -35     
+ Misses          9        8       -1     
+ Partials        5        0       -5     
Files Coverage Δ
src/in_place/__init__.py 94.96% <94.96%> (ø)

@jwodder jwodder marked this pull request as ready for review October 11, 2023 23:06
@jwodder jwodder merged commit 11d843b into master Oct 12, 2023
54 checks passed
@jwodder jwodder deleted the v1.0 branch October 12, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Introduction of an incompatible API change enhancement New feature or request therefor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming breaking changes in v1.0 Mypy type compliance
1 participant