Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow writing cmdclasses in setup.cfg #43

Closed
mttbernardini opened this issue Jan 23, 2023 · 2 comments · Fixed by #44
Closed

Allow writing cmdclasses in setup.cfg #43

mttbernardini opened this issue Jan 23, 2023 · 2 comments · Fixed by #44
Labels
builder:setuptools Integration with setuptools build backend enhancement New feature or request therefor

Comments

@mttbernardini
Copy link

mttbernardini commented Jan 23, 2023 •
edited
Loading

Hi,

I noticed that in order to use the onbuild step, I need to explicitly create a setup.py and invoke setup() by passing the cmclasses returned by versioningit.get_cmdclasses().

Since setuptools supports the definition of cmdclasses in setup.cfg (and potentially pyproject.toml, I didn't check, see pypa/setuptools#2570 for reference), would it be possible to expose the needed cmdclasses in the cmdclasses.py module so that they can be used in this form, avoiding having to create a setup.py specifically for this use case?

Thank you for this tool, it's quite helpful!
@jwodder jwodder mentioned this issue Feb 4, 2023
Merged
@jwodder jwodder added the enhancement New feature or request therefor label Feb 4, 2023
@jwodder
Copy link
Owner

jwodder commented Feb 4, 2023

Thanks for the suggestion! My apologies for the delay. I've implemented this in PR #44; unless I hear otherwise, I plan to merge & release in one week.

jwodder added a commit that referenced this issue Feb 11, 2023
@jwodder
Merge pull request #44 from jwodder/gh-43
2b94523 
Add importable setuptools command classes for use in `setup.cfg`
@jwodder
Copy link
Owner

jwodder commented Feb 11, 2023

This feature is now available in versioningit v2.2.0.

@jwodder jwodder added the builder:setuptools Integration with setuptools build backend label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builder:setuptools Integration with setuptools build backend enhancement New feature or request therefor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add importable setuptools command classes for use in setup.cfg jwodder/versioningit
2 participants
@jwodder @mttbernardini