Multiple modules: do not use bidderTimeout as TTL (prebid#9880)

* Multiple modules: do not use bidderTimeout as TTL * Fix lint
jwplayer · May 18, 2023 · cf899ce · cf899ce
1 parent d403664
commit cf899ce
Show file tree

Hide file tree

Showing 11 changed files with 37 additions and 49 deletions.
diff --git a/modules/ablidaBidAdapter.js b/modules/ablidaBidAdapter.js
@@ -1,8 +1,7 @@
-import { triggerPixel } from '../src/utils.js';
-import {config} from '../src/config.js';
+import {triggerPixel} from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
-import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
-import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
+import {BANNER, NATIVE, VIDEO} from '../src/mediaTypes.js';
+import {convertOrtbRequestToProprietaryNative} from '../src/native.js';
 
 const BIDDER_CODE = 'ablida';
 const ENDPOINT_URL = 'https://bidder.ablida.net/prebid';
@@ -77,7 +76,7 @@ export const spec = {
     const response = serverResponse.body;
 
     response.forEach(function(bid) {
-      bid.ttl = config.getConfig('_bidderTimeout');
+      bid.ttl = 60
       bidResponses.push(bid);
     });
     return bidResponses;

diff --git a/modules/axonixBidAdapter.js b/modules/axonixBidAdapter.js
@@ -1,8 +1,8 @@
-import { isArray, logError, deepAccess, isEmpty, triggerPixel, replaceAuctionPrice } from '../src/utils.js';
-import { registerBidder } from '../src/adapters/bidderFactory.js';
-import { BANNER, VIDEO } from '../src/mediaTypes.js';
-import { config } from '../src/config.js';
-import { ajax } from '../src/ajax.js';
+import {deepAccess, isArray, isEmpty, logError, replaceAuctionPrice, triggerPixel} from '../src/utils.js';
+import {registerBidder} from '../src/adapters/bidderFactory.js';
+import {BANNER, VIDEO} from '../src/mediaTypes.js';
+import {config} from '../src/config.js';
+import {ajax} from '../src/ajax.js';
 
 const BIDDER_CODE = 'axonix';
 const BIDDER_VERSION = '1.0.2';
@@ -150,7 +150,7 @@ export const spec = {
     for (const resp of response) {
       if (resp.requestId) {
         responses.push(Object.assign(resp, {
-          ttl: config.getConfig('_bidderTimeout')
+          ttl: 60
         }));
       }
     }

diff --git a/modules/dspxBidAdapter.js b/modules/dspxBidAdapter.js
@@ -1,5 +1,4 @@
-import {deepAccess, getBidIdParameter, logError, logMessage, logWarn, isFn} from '../src/utils.js';
-import {config} from '../src/config.js';
+import {deepAccess, getBidIdParameter, isFn, logError, logMessage, logWarn} from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
 import {BANNER, VIDEO} from '../src/mediaTypes.js';
 import {Renderer} from '../src/Renderer.js';
@@ -183,7 +182,7 @@ export const spec = {
         currency: currency,
         netRevenue: netRevenue,
         type: response.type,
-        ttl: config.getConfig('_bidderTimeout'),
+        ttl: 60,
         meta: {
           advertiserDomains: response.adomain || []
         }

diff --git a/modules/iqmBidAdapter.js b/modules/iqmBidAdapter.js
@@ -1,6 +1,5 @@
 import {_each, deepAccess, getBidIdParameter, isArray} from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
-import {config} from '../src/config.js';
 import {BANNER, VIDEO} from '../src/mediaTypes.js';
 import {INSTREAM} from '../src/video.js';
 
@@ -155,7 +154,7 @@ export const spec = {
               auctionId: bidRequest.data.auctionId,
               mediaType: bidRequest.data.imp.mediatype,
 
-              ttl: bid.ttl || config.getConfig('_bidderTimeout')
+              ttl: bid.ttl || 60
             };
 
             if (bidRequest.data.imp.mediatype === VIDEO) {

diff --git a/modules/orbitsoftBidAdapter.js b/modules/orbitsoftBidAdapter.js
@@ -1,6 +1,5 @@
 import * as utils from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
-import {config} from '../src/config.js';
 
 const BIDDER_CODE = 'orbitsoft';
 let styleParamsMap = {
@@ -122,7 +121,7 @@ export const spec = {
     const HEIGHT = serverBody.height;
     const CREATIVE = serverBody.content_url;
     const CALLBACK_UID = serverBody.callback_uid;
-    const TIME_TO_LIVE = config.getConfig('_bidderTimeout');
+    const TIME_TO_LIVE = 60;
     const REFERER = utils.getWindowTop();
     let bidRequest = request.bidRequest;
     if (CPM > 0 && WIDTH > 0 && HEIGHT > 0) {

diff --git a/modules/radsBidAdapter.js b/modules/radsBidAdapter.js
@@ -1,7 +1,6 @@
-import { deepAccess } from '../src/utils.js';
-import {config} from '../src/config.js';
+import {deepAccess} from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
-import { BANNER, VIDEO } from '../src/mediaTypes.js';
+import {BANNER, VIDEO} from '../src/mediaTypes.js';
 
 const BIDDER_CODE = 'rads';
 const ENDPOINT_URL = 'https://rads.recognified.net/md.request.php';
@@ -86,7 +85,7 @@ export const spec = {
         dealId: dealId,
         currency: currency,
         netRevenue: netRevenue,
-        ttl: config.getConfig('_bidderTimeout'),
+        ttl: 60,
         meta: {
           advertiserDomains: response.adomain || []
         }

diff --git a/modules/stvBidAdapter.js b/modules/stvBidAdapter.js
@@ -1,7 +1,6 @@
-import { deepAccess } from '../src/utils.js';
-import { config } from '../src/config.js';
-import { registerBidder } from '../src/adapters/bidderFactory.js';
-import { BANNER, VIDEO } from '../src/mediaTypes.js';
+import {deepAccess} from '../src/utils.js';
+import {registerBidder} from '../src/adapters/bidderFactory.js';
+import {BANNER, VIDEO} from '../src/mediaTypes.js';
 import {includes} from '../src/polyfill.js';
 
 const BIDDER_CODE = 'stv';
@@ -128,7 +127,7 @@ export const spec = {
         dealId: dealId,
         currency: currency,
         netRevenue: netRevenue,
-        ttl: config.getConfig('_bidderTimeout'),
+        ttl: 60,
         meta: {
           advertiserDomains: response.adomain || []
         }

diff --git a/modules/underdogmediaBidAdapter.js b/modules/underdogmediaBidAdapter.js
@@ -1,21 +1,18 @@
 import {
-  logMessage,
+  deepAccess,
   flatten,
-  parseSizesInput,
+  getWindowSelf,
+  getWindowTop,
   isGptPubadsDefined,
   isSlotMatchingAdUnitCode,
   logInfo,
+  logMessage,
   logWarn,
-  getWindowSelf,
-  getWindowTop,
-  deepAccess
+  parseSizesInput
 } from '../src/utils.js';
-import {
-  config
-} from '../src/config.js';
-import {
-  registerBidder
-} from '../src/adapters/bidderFactory.js';
+import {config} from '../src/config.js';
+import {registerBidder} from '../src/adapters/bidderFactory.js';
+
 const BIDDER_CODE = 'underdogmedia';
 const UDM_ADAPTER_VERSION = '7.30V';
 const UDM_VENDOR_ID = '159';
@@ -377,7 +374,7 @@ function makeNotification(bid, mid, bidParam) {
   url += `;version=${UDM_ADAPTER_VERSION}`;
   url += ';cb=' + Math.random();
   url += ';qqq=' + (1 / bid.cpm);
-  url += ';hbt=' + config.getConfig('_bidderTimeout');
+  url += ';hbt=' + config.getConfig('bidderTimeout');
   url += ';style=adapter';
   url += ';vis=' + encodeURIComponent(document.visibilityState);
 

diff --git a/modules/vdoaiBidAdapter.js b/modules/vdoaiBidAdapter.js
@@ -1,5 +1,4 @@
-import { getAdUnitSizes } from '../src/utils.js';
-import {config} from '../src/config.js';
+import {getAdUnitSizes} from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
 import {BANNER, VIDEO} from '../src/mediaTypes.js';
 
@@ -87,7 +86,7 @@ export const spec = {
         // dealId: dealId,
         currency: currency,
         netRevenue: netRevenue,
-        ttl: config.getConfig('_bidderTimeout'),
+        ttl: 60,
         // referrer: referrer,
         // ad: response.adm
         // ad: adCreative,

diff --git a/modules/wipesBidAdapter.js b/modules/wipesBidAdapter.js
@@ -1,5 +1,4 @@
-import { logWarn } from '../src/utils.js';
-import {config} from '../src/config.js';
+import {logWarn} from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
 import {BANNER} from '../src/mediaTypes.js';
 
@@ -50,7 +49,7 @@ function interpretResponse(serverResponse, bidRequest) {
       dealId: response.deal_id,
       currency: 'JPY',
       netRevenue: netRevenue,
-      ttl: config.getConfig('_bidderTimeout'),
+      ttl: 60,
       referrer: bidRequest.data.r || '',
       mediaType: BANNER,
       ad: response.ad_tag,

diff --git a/modules/yieldoneBidAdapter.js b/modules/yieldoneBidAdapter.js
@@ -1,8 +1,7 @@
 import {deepAccess, isEmpty, isStr, logWarn, parseSizesInput} from '../src/utils.js';
-import {config} from '../src/config.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
-import { Renderer } from '../src/Renderer.js';
-import { BANNER, VIDEO } from '../src/mediaTypes.js';
+import {Renderer} from '../src/Renderer.js';
+import {BANNER, VIDEO} from '../src/mediaTypes.js';
 
 /**
  * @typedef {import('../src/adapters/bidderFactory').Bid} Bid
@@ -147,7 +146,7 @@ export const spec = {
         dealId: dealId,
         currency: currency,
         netRevenue: netRevenue,
-        ttl: config.getConfig('_bidderTimeout'),
+        ttl: 60,
         referrer: referrer,
         meta: {
           advertiserDomains: response.adomain ? response.adomain : []