Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix queue undefined with audiovideo fmp4 #250

Closed
wants to merge 6 commits into from

Conversation

xmedia-systems
Copy link

@xmedia-systems xmedia-systems commented Sep 26, 2019

Resolves issues: when playing fmp4 source with audiovideo stream no BufferOperationQueue is found causing "queue is undefined" exception

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@jwplayer-robot
Copy link

Can one of the admins verify this patch?

Copy link

@robwalch robwalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add steps to reproduce (with a test stream if possible), and add tests to tests/unit/controller/buffer-operation-queue.ts

@robwalch
Copy link

robwalch commented Oct 9, 2019

This has been addressed in jwplayer:LHLS:

controller/buffer-operation-queue.ts

export default class BufferOperationQueue {
  private buffers: SourceBuffers;
  private queues: BufferOperationQueues = {
    video: [],
    audio: [],
    audiovideo: []
  };

types/buffers.ts

export interface BufferOperationQueues {
  video: Array<BufferOperation>;
  audio: Array<BufferOperation>;
  audiovideo: Array<BufferOperation>;
}

@xmedia-systems the LHLS branch was rebased (force-pushed) last week and updated this week with the work done upstream in video-dev#2389 and video-dev#2370

@robwalch robwalch closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants