Skip to content

Commit

Permalink
drm/i915/display: Add a intel_pipe_is_enabled() helper
Browse files Browse the repository at this point in the history
Factor the code to check if a pipe is currently enabled out of
assert_pipe() and put it in a new intel_pipe_is_enabled() helper,
so that it can be re-used without copy-pasting it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
  • Loading branch information
jwrdegoede committed Apr 7, 2024
1 parent b5183b4 commit 71280d4
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
20 changes: 14 additions & 6 deletions drivers/gpu/drm/i915/display/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -303,17 +303,13 @@ intel_wait_for_pipe_off(const struct intel_crtc_state *old_crtc_state)
}
}

void assert_transcoder(struct drm_i915_private *dev_priv,
enum transcoder cpu_transcoder, bool state)
bool intel_pipe_is_enabled(struct drm_i915_private *dev_priv,
enum transcoder cpu_transcoder)
{
bool cur_state;
enum intel_display_power_domain power_domain;
intel_wakeref_t wakeref;

/* we keep both pipes enabled on 830 */
if (IS_I830(dev_priv))
state = true;

power_domain = POWER_DOMAIN_TRANSCODER(cpu_transcoder);
wakeref = intel_display_power_get_if_enabled(dev_priv, power_domain);
if (wakeref) {
Expand All @@ -325,6 +321,18 @@ void assert_transcoder(struct drm_i915_private *dev_priv,
cur_state = false;
}

return cur_state;
}

void assert_transcoder(struct drm_i915_private *dev_priv,
enum transcoder cpu_transcoder, bool state)
{
bool cur_state = intel_pipe_is_enabled(dev_priv, cpu_transcoder);

/* we keep both pipes enabled on 830 */
if (IS_I830(dev_priv))
state = true;

I915_STATE_WARN(dev_priv, cur_state != state,
"transcoder %s assertion failure (expected %s, current %s)\n",
transcoder_name(cpu_transcoder), str_on_off(state),
Expand Down
2 changes: 2 additions & 0 deletions drivers/gpu/drm/i915/display/intel_display.h
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,8 @@ void intel_enable_transcoder(const struct intel_crtc_state *new_crtc_state);
void intel_disable_transcoder(const struct intel_crtc_state *old_crtc_state);
void i830_enable_pipe(struct drm_i915_private *dev_priv, enum pipe pipe);
void i830_disable_pipe(struct drm_i915_private *dev_priv, enum pipe pipe);
bool intel_pipe_is_enabled(struct drm_i915_private *dev_priv,
enum transcoder cpu_transcoder);
int vlv_get_hpll_vco(struct drm_i915_private *dev_priv);
int vlv_get_cck_clock(struct drm_i915_private *dev_priv,
const char *name, u32 reg, int ref_freq);
Expand Down

0 comments on commit 71280d4

Please sign in to comment.