Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor repositories API #232

Merged
merged 12 commits into from Jan 18, 2021
Merged

Refactor repositories API #232

merged 12 commits into from Jan 18, 2021

Conversation

jamowei
Copy link
Collaborator

@jamowei jamowei commented Dec 14, 2020 •
edited

Improve API for Repositories

@jwstegemann
Copy link
Owner

Would it be a good idea to separate RessourceSerializer and RessourceListSerializer so you don't have to implement methods zog won't need?

@jwstegemann
Copy link
Owner

@jamowei what do you think?

@jamowei jamowei marked this pull request as draft December 22, 2020 16:41
@jamowei jamowei marked this pull request as ready for review December 23, 2020 15:23
@jamowei
Copy link
Collaborator Author

jamowei commented Dec 23, 2020 •
edited

@jamowei what do you think?

You are right, I changed the default implementation of RessourceSerializer and did a bunch of other things. Please review again.

@jamowei jamowei changed the title Jamowei/refactor repositories Refactor repositories API Dec 30, 2020
@jamowei jamowei added this to the 0.9 milestone Jan 14, 2021
@jwstegemann jwstegemann merged commit 30ff636 into master Jan 18, 2021
@jwstegemann jwstegemann deleted the jamowei/refactorRepositories branch January 18, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwstegemann jwstegemann jwstegemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamowei @jwstegemann