Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using QuerySelecor instead of id #243

Merged
merged 26 commits into from Jan 18, 2021
Merged

Using QuerySelecor instead of id #243

merged 26 commits into from Jan 18, 2021

Conversation

jamowei
Copy link
Collaborator

@jamowei jamowei commented Jan 18, 2021

Fixes #241 and fixes #226

chausknecht and others added 26 commits December 16, 2020 10:16
Improve flow processing speed
e794fc7 
- choose better fitting start strategy for handling a single mount point
Merge branch 'retypeRenderContext' of https://github.com/jwstegemann/…
f7ae988 
…fritz2 into retypeRenderContext
Refactor RenderContext
49129a2 
- renamed old ``RenderContext`` interface into ``HtmlElements``
- introduced new type alias called ``RenderContext`` as meaningful shorthand for ``Tag<HtmlElement>``
- adopt parameter naming to new interface name
- reworked changes of PR#230 to make components more flexible again which kind of HTML content they accept (the new type ``RenderContext`` should be the preferred one in general until there are good reasons to restrict it!)
@jamowei
removed not needed import
ef31420
@jamowei
reworked global render and Tag.render functions entirely
f4cbb33
@jamowei
fixed not needed method appendToBody
3082b7f
@jamowei
handle MultipleRootElementsException in mountSingle function
b7df6d8
@jamowei
fixed new global render function in tests
3555f19
@jamowei
making parentElement in global render function nullable
334b974
@jamowei
putting new register functions in Tag companion object for better gro…
5cd3f60 
…uping
@jamowei
adding global functions for creating Tags and mounting them
cf87bc7
@jamowei
fixed compile error
523ecc0
@jamowei
added tests
9b346ac
Apply RenderContext to components and minor stuff
0844320 
- retype ``HtmlElements`` to new ``RenderContext`` type for components
- add missing render function variant
- improve readability by making boolean parameter explicit in order
  to enhance readability of the ``render`` function call.
- improve API documentation
@jamowei
changed from RuntimeException to Exception
d723795
@jamowei
better error message in MountTargetNotFoundException
b75a580
@jamowei
adding document.body as default for targetElement in global render fu…
a386f31 
…nction
@jamowei
simplify tests
282bce8
@jamowei
Merge remote-tracking branch 'origin/retypeRenderContext' into retype…
e24e62b 
…RenderContext
@jamowei
added fixmes + better kdoc
edcf532
@jamowei
cleanup tag
1c16548
@jamowei
better exception handling in Flows
4c6740b
@jamowei
renamed HtmlElements to TagContext
bc913a2
@jamowei
removed (probably) not needed tag function
a25e62a
@jamowei
fixed tests
f7f4ef6
@jamowei
using querySelector instead of id + fixed removing of child elements
cfebf3c
@jamowei jamowei added this to the 0.9 milestone Jan 18, 2021
@jwstegemann jwstegemann merged commit 7748677 into master Jan 18, 2021
@jwstegemann jwstegemann deleted the jamowei/querySelecor branch January 18, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwstegemann jwstegemann jwstegemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

Support querySelecor for global render function mount does not remove existing content
2 participants
@jamowei @jwstegemann