Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize toast behaviour #285

Merged
merged 1 commit into from Mar 1, 2021
Merged

Harmonize toast behaviour #285

merged 1 commit into from Mar 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 1, 2021

  • The rendering sequence now depends on the basic placement: New toasts should always be stacked on existing ones, which naturally depends on the basic placement:
    • top: the new toast must be rendered below the existing ones
    • bottom: the new toast must be rendered above the existing ones (reverse order needed)

@ghost ghost added the bug Something isn't working label Mar 1, 2021
@ghost ghost requested review from jamowei and jwstegemann March 1, 2021 13:33
@ghost ghost added this to the 0.9 milestone Mar 1, 2021
Harmonize toast behaviour
95ef499 
- The rendering sequence now depends on the basic placement: New toasts should always be stacked on existing ones, which naturally depends on the basic placement:
  - top: the new toast must be rendered *below* the existing ones
  - bottom: the new toast must be rendered *above* the existing ones (reverse order needed)
@jamowei jamowei merged commit d9a8a13 into master Mar 1, 2021
@jamowei jamowei deleted the chausknecht/harmonizeToastBehaviour branch March 1, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwstegemann jwstegemann Awaiting requested review from jwstegemann

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jamowei