Improves and enhances the reactive styling #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation is still missing, so I reset this do draft. |
Lysander
force-pushed
the
chausknecht/tryBetterReactiveStyling
branch
from
1d50c34
to
1998af2
Compare
metin-kale
previously approved these changes
Nov 30, 2023
Lysander
dismissed
metin-kale’s stale review
The merge-base changed after approval.
Lysander
force-pushed
the
chausknecht/tryBetterReactiveStyling
branch
3 times, most recently
from
8ee4855
to
9f29db6
Compare
- removes `addToClasses` functions. Migration: Just rename all occurrences to `className`. - substitutes the internal class name management with a `MutableStateFlow` based approach, where the former manages all different portions of the overall class names, so those can get merged appropriately and mounted only once into the tag's `class` attribute. - add a new `className`-function variant: This generic function accepts some `Flow[T]`, which is then be used by some lamba expression to generate the class names. Additionally the calles must also provide some initial `T`, which is used to create the initial class names that gets set immediately to the DOM, without needing to wait for the flow's first value. - add unit tests for new `className`-functions - add and adapt documentation - updates Playwright to version 1.40.1
Lysander
force-pushed
the
chausknecht/tryBetterReactiveStyling
branch
from
9f29db6
to
8ecdcbe
Compare
|
This PR is api-breaking please provide a migration guide for the release notes ( |
jamowei
approved these changes
Dec 1, 2023
EvaBS
added a commit
that referenced
this pull request
Dec 4, 2023
Lysander
pushed a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the improved styling can be found in our documentation:
General Function
Avoid Flicker Effects
removes
addToClassesfunctions. Migration: Just rename all occurrences toclassName.substitutes the internal class name management with a
MutableStateFlowbased approach, where the former manages all different portions of the overall class names, so those can get merged appropriately and mounted only once into the tag'sclassattribute.add a new
className-function variant: This generic function accepts someFlow[T], which is then be used by some lamba expression to generate the class names. Additionally the calles must also provide some initialT, which is used to create theinitial class names that gets set immediately to the DOM, without needing to wait for the flow's first value.
add unit tests for new
className-functionadd and adapt documentation
updates Playwright to version 1.40.1