Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES256K (secp256k1) #626

Closed
youngjoon-lee opened this issue Oct 29, 2020 · 3 comments
Closed

Support ES256K (secp256k1) #626

youngjoon-lee opened this issue Oct 29, 2020 · 3 comments

Comments

@youngjoon-lee
Copy link

youngjoon-lee commented Oct 29, 2020

Hi all,

I'm trying to use this library for my platform, but my platform has been using ES256K keys, not ES256.

Do you have any plan to support ES256K? It seems there have been no discussions about ES256K in this repo.
If you think it's reasonable, I can open a PR :)

Please consider and let me know if I can do it.

@youngjoon-lee
Copy link
Author

youngjoon-lee commented Nov 3, 2020

@lhazlewood Could you review this issue?

@stale stale bot added the stale Stale issues pending deletion due to inactivity label Jan 6, 2021
@youngjoon-lee
Copy link
Author

@lhazlewood Hi. Could you review this PR?

@stale stale bot removed the stale Stale issues pending deletion due to inactivity label Jan 6, 2021
@jwtk jwtk deleted a comment from stale bot Feb 19, 2021
@lhazlewood
Copy link
Contributor

I don't understand the purpose for this PR - why did you create an alternative name for ES256?

The JJWT team will only support specification-defined algorithms, not custom ones. When #178 is complete however, you'll be able to add custom algorithms in your own project, so that might solve this use case? Please advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants