Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignatureAlgorithm names in document confusion #764

Closed
NoahELE opened this issue Dec 17, 2022 · 3 comments
Closed

SignatureAlgorithm names in document confusion #764

NoahELE opened this issue Dec 17, 2022 · 3 comments
Milestone
0.12.0

Comments

@NoahELE
Copy link

NoahELE commented Dec 17, 2022

Describe the bug
I am confused of this EC256, I guess that it might be a typo for ES256.

Tried to google EC256 and found nothing.

Thanks!

Screenshots
Screenshot of idea doc popup:
image
@Ivanmatthew
Copy link
Contributor

Just here to say you are correct; it's supposed to be ES256, ES384 and ES512 respectively.

@lhazlewood
Copy link
Contributor

Good catch! Would you mind opening a PR for the quick fix?

Ivanmatthew added a commit to Ivanmatthew/jjwt that referenced this issue May 19, 2023
@Ivanmatthew
Changed javadoc typos
7c9c82c 
Related issue jwtk#764 

EC256 > ES256
EC384 > ES384
EC512 > ES512
@Ivanmatthew Ivanmatthew mentioned this issue May 19, 2023
Merged
lhazlewood pushed a commit that referenced this issue May 19, 2023
@Ivanmatthew
Changed javadoc typos (#782)
992d75d 
Related issue #764 

EC256 > ES256
EC384 > ES384
EC512 > ES512
@lhazlewood lhazlewood added this to the 0.12.0 milestone Aug 11, 2023
@lhazlewood
Copy link
Contributor

Closing now that 992d75d has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
3 participants
@lhazlewood @NoahELE @Ivanmatthew