make_objectmapper_static #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhazlewood
reviewed
May 16, 2017
| @@ -59,7 +59,7 @@ | |||
| private static final String ISO_8601_FORMAT = "yyyy-MM-dd'T'HH:mm:ss'Z'"; | |||
| private static final int MILLISECONDS_PER_SECOND = 1000; | |||
|
|
|||
| private ObjectMapper objectMapper = new ObjectMapper(); | |||
There was a problem hiding this comment.
I'm not sure we want to do this - it might be configurable in the future to configure a parser with its own objectmapper instance (e.g. for pretty printing or whatever)
kpronovost
reviewed
Dec 5, 2017
| @@ -59,7 +59,7 @@ | |||
| private static final String ISO_8601_FORMAT = "yyyy-MM-dd'T'HH:mm:ss'Z'"; | |||
| private static final int MILLISECONDS_PER_SECOND = 1000; | |||
|
|
|||
| private ObjectMapper objectMapper = new ObjectMapper(); | |||
There was a problem hiding this comment.
I agree with @lhazlewood
It'd be better to be able to set the ObjectMapper. That being said, it is currently not the case and I would say it would be better to be consistant throught the different classes.
If the static is added though, please rename to OBJECT_MAPPER
|
This has been resolved via #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes ObjectMapper static in DefaultJwtParser.
See: http://wiki.fasterxml.com/JacksonBestPracticesPerformance