Audience String array #238
Conversation
|
It seems like Travis CI configuration for JDK7 is broken :( |
In previous versions, you can only set the complete value of the audience field. Now you can set as mandatory one or multiple audiences when you are parsing the token and, internally the library will check if the parsed audiences contains all of them.
|
Please merge master to your branch. the jdk7 issue is fixed. Thanks! |
Merge Travis configuration fixes in forked master
Updated Travis configuration
|
For reference: https://tools.ietf.org/html/rfc7519#section-4.1.3 Since this is an interface change and in its current form is not backwards compatible, it would have to be released with a major version release, probably 1.0. Since the spec indicates that for a single audience a string is acceptable, perhaps it should be able to handle both a simple String and a String array? |
|
We are really looking forward to this feature because we want to share a web service amongst multiple clients, which have tokens containing different aud claims. |
|
@dogeared I've made the changes requested. The changes keep the API to handle String in the audience attribute, adding support to handle String array. |
|
Hi all! Is there a plan to have this merged to master? Do you need help on this? |
|
I have updated again the branch with the latest changes in master. I have to check why tests are now failing. I will update the PR as soon as I can! |
|
I cannot not find time to correctly review this PR I started almost three years ago. Sorry. The project has evolved during this time and my proposed implementation is practically invalid with the current codebase so I close this PR. I'm also going to archive my fork project since I will not continue working on this feature. Please feel free to reopen the PR or use the repository as a reference in case someone wants to continue this functionality. Thank you for your time @dogeared ! |
Added suport to Array of String for Audience #77