Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search breaks if \ is included #452

Closed
jwu910 opened this issue Sep 12, 2019 · 2 comments
Closed

Search breaks if \ is included #452

jwu910 opened this issue Sep 12, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@jwu910
Copy link
Owner

jwu910 commented Sep 12, 2019 •
edited

Backslash is breaking search

This is related to attempted search with invalid regex patterns.
We should be validating search patterns before passing that search value to the search method
jwu910 added a commit that referenced this issue Sep 12, 2019
@jwu910
fix(interface.js): Replaces backslash with double backslash before se…
9c539a8 
…arch, adds log messages for sea

fixes #452
@jwu910 jwu910 mentioned this issue Sep 12, 2019
Closed
jwu910 added a commit that referenced this issue Sep 12, 2019
@jwu910
docs(CHANGELOG.md): Update changelog
f0f5819 
re #452
@jwu910 jwu910 added the bug Something isn't working label Sep 13, 2019
@jwu910
Copy link
Owner Author

jwu910 commented Oct 5, 2019

@all-contributors please add drewbrokke for maintenance and ideas

@allcontributors allcontributors bot mentioned this issue Oct 5, 2019
Merged
@allcontributors
Copy link
Contributor

@jwu910

I've put up a pull request to add @drewbrokke! 🎉

@jwu910 jwu910 added the pending-release Reviewed and merged into development label Oct 10, 2019
@jwu910 jwu910 closed this as completed Oct 13, 2019
@jwu910 jwu910 removed the pending-release Reviewed and merged into development label Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CIO-452 jwu910/check-it-out
1 participant
@jwu910