Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Artifact Registry #55

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

sergiogiuffrida
Copy link
Contributor

Added GCP Artifact Registry support and customisable.

merge after jenkins-x/terraform-google-jx#235

main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
default = "oci"
}
variable "artifact_description" {
description = "artifact registry repository Description"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix weird casing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. It should be fixed in the other descriptions and in terraform-google-jx as well. Some other time...

default = "oci"
}
variable "artifact_description" {
description = "artifact registry repository Description"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. It should be fixed in the other descriptions and in terraform-google-jx as well. Some other time...

@msvticket msvticket merged commit 4b48a3e into jx3-gitops-repositories:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants