fixed timestamp_us overflow #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packing timestamp_us into a 32-bit unsigned integer, struct.pack can throws an exception if the number is bigger than 2^32. Some software sets the frame timestamp to be time.time(), meaning that the exception is thrown immediately. (see scapy: https://github.com/secdev/scapy/blob/master/scapy/contrib/cansocket_python_can.py#L319) I would recommend doing a bitwise and with 0xffffffff to ensure the timestamp fits into the 32-bit integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packing timestamp_us into a 32-bit unsigned integer, struct.pack can throws an exception if the number is bigger than 2^32.
Some software sets the frame timestamp to be time.time(), meaning that the exception is thrown immediately. (see scapy: https://github.com/secdev/scapy/blob/master/scapy/contrib/cansocket_python_can.py#L319)
I would recommend doing a bitwise and with 0xffffffff to ensure the timestamp fits into the 32-bit integer