Skip to content
This repository has been archived by the owner on Jul 26, 2019. It is now read-only.

Supports of SVG tags #1

Closed
zoontek opened this issue Jul 14, 2018 · 2 comments
Closed

Supports of SVG tags #1

zoontek opened this issue Jul 14, 2018 · 2 comments

Comments

@zoontek
Copy link

zoontek commented Jul 14, 2018

Hello @jxnblk,

Horror is a great lib, I really enjoy styling my components like this.
Do you have plan to add support for svg tags? Maybe with a dependency like https://www.npmjs.com/package/svg-tags

I could do the PR if you want 🙂

@jxnblk
Copy link
Owner

jxnblk commented Jul 14, 2018

Thanks! I think you can use SVGs now with the is prop – e.g. <H is='path' />, but it could make sense to have an optional horror/svg module with shortcuts like H.path and H.Path. Quickly glancing at the code, it looks like it's looping through html-tags in a couple places, and I think that could be DRYed up and passed as a second options argument to the create function, if you wanna take a stab at a PR

@zoontek
Copy link
Author

zoontek commented Jul 15, 2018

@jxnblk I understand, but what about emotion support? Should I add the optional horror/emotion/svg too? Or maybe add create a conditional to import styled-components OR react-emotion?

@jxnblk jxnblk closed this as completed Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants