-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile layout & touchscreen UI #6
Comments
I started tinkering by adding some onClick/onMouseUp/onTouchEnd handlers to the Carousel, but there was no immediate way to test on device with hot reloading. I'm posting some tweaks here for those wishing to develop and test for mobile. ok-cli (and hence mdx-deck's cli) don't offer a host (or host/client pair) option on the command line, so I modified ok-cli's hotClient options (node_modules/ok-cli/lib/index.js):
as per webpack-hot-client's Remote Machine README. I specified a port to make refreshing/reloading the URL on the phone easier. Webpack will only hot-reload on one browser/device at a time, which means you have to close the tab that |
This is @jxnblk's project that he's graciously sharing with everyone. I think it's safe to assume that most OSS projects, including this one, are put out there for others to 1) learn from and use what the developer has created and 2) contribute back to the project if they like. Anyone can be a developer, even if that's not their full-time profession. So you and your friend are certainly welcome to tinker just as I am. Brent hasn't put out any specifications or guidelines for contributions yet; he's just putting out placeholders. |
@jxnblk I'm interested in trying |
@appsforartists Seems like #69 added invisible Previous and Next buttons to the UI already. Example here: https://relay-modern-course.now.sh/packages/01-setup/#0 If you want the buttons to be visible, it seems like a good bet to build a custom provider: https://github.com/jxnblk/mdx-deck/blob/master/docs/advanced.md#custom-provider-component |
Thanks.
doesn't add any buttons with |
After some digging, it looks like those buttons may have been replaced by https://github.com/dogfessional/react-swipeable. |
@appsforartists @karlhorky check 👇 |
@kuldeepkeshwar did you add this feature? Will you open a PR for it? |
@karlhorky yup, all you need to do it, open the URL in Mobile & do add to the home screen. Open screen for the audience on any other device(Laptop/Project/TV). PWA opens in I will raise the PR soon, some refactoring I need to do, meanwhile, you can use this fork |
raised PR #375 🙂 |
Closing this for now. More specific, new issues can be opened to cover any mobile-related feature requests |
viewport-fit=cover
The text was updated successfully, but these errors were encountered: