Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile layout & touchscreen UI #6

Closed
2 of 6 tasks
jxnblk opened this issue Jul 29, 2018 · 12 comments
Closed
2 of 6 tasks

Mobile layout & touchscreen UI #6

jxnblk opened this issue Jul 29, 2018 · 12 comments
Labels
enhancement New feature or request

Comments

@jxnblk
Copy link
Owner

jxnblk commented Jul 29, 2018

@jxnblk jxnblk added bug Something isn't working enhancement New feature or request labels Jul 30, 2018
@SirBryan
Copy link

I started tinkering by adding some onClick/onMouseUp/onTouchEnd handlers to the Carousel, but there was no immediate way to test on device with hot reloading. I'm posting some tweaks here for those wishing to develop and test for mobile.

ok-cli (and hence mdx-deck's cli) don't offer a host (or host/client pair) option on the command line, so I modified ok-cli's hotClient options (node_modules/ok-cli/lib/index.js):

  const hotClient = {
    host: { client: '*', server: '0.0.0.0' },
    port: opts.hotPort,
    logLevel: 'error'
  }

as per webpack-hot-client's Remote Machine README.

I specified a port to make refreshing/reloading the URL on the phone easier. Webpack will only hot-reload on one browser/device at a time, which means you have to close the tab that npm start opens (--no-open doesn't seem to work), then refresh the phone's browser.

@SirBryan
Copy link

This is @jxnblk's project that he's graciously sharing with everyone. I think it's safe to assume that most OSS projects, including this one, are put out there for others to 1) learn from and use what the developer has created and 2) contribute back to the project if they like.

Anyone can be a developer, even if that's not their full-time profession. So you and your friend are certainly welcome to tinker just as I am. Brent hasn't put out any specifications or guidelines for contributions yet; he's just putting out placeholders.

@appsforartists
Copy link

@jxnblk I'm interested in trying mdx-deck for an interactive presentation that I'll be running from a tablet. Can you please point me in the right direction for adding prev/next buttons to a presentation?

@karlhorky
Copy link
Contributor

karlhorky commented Apr 20, 2019

@appsforartists Seems like #69 added invisible Previous and Next buttons to the UI already.

Screen Shot 2019-04-20 at 15 10 07

Example here:

https://relay-modern-course.now.sh/packages/01-setup/#0

If you want the buttons to be visible, it seems like a good bet to build a custom provider: https://github.com/jxnblk/mdx-deck/blob/master/docs/advanced.md#custom-provider-component

@appsforartists
Copy link

Thanks.

yarn run mdx-deck ./src/deck.mdx

doesn't add any buttons with mdx-deck@2.2.1; my DOM doesn't look like yours. I'll look into providers.

@appsforartists
Copy link

After some digging, it looks like those buttons may have been replaced by https://github.com/dogfessional/react-swipeable.

@kuldeepkeshwar
Copy link

@appsforartists @karlhorky check 👇
https://twitter.com/kuldeepkeshwar/status/1136370461028126721
I hope this is what you were looking for 😉

@kuldeepkeshwar
Copy link

@karlhorky
Copy link
Contributor

@kuldeepkeshwar did you add this feature? Will you open a PR for it?

@kuldeepkeshwar
Copy link

@karlhorky yup, all you need to do it, open the URL in Mobile & do add to the home screen. Open screen for the audience on any other device(Laptop/Project/TV).

PWA opens in mobile mode which has navigation buttons.

I will raise the PR soon, some refactoring I need to do, meanwhile, you can use this fork

@kuldeepkeshwar
Copy link

raised PR #375 🙂

@jxnblk
Copy link
Owner Author

jxnblk commented Jul 9, 2019

Closing this for now. More specific, new issues can be opened to cover any mobile-related feature requests

@jxnblk jxnblk closed this as completed Jul 9, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants
@appsforartists @SirBryan @karlhorky @jxnblk @kuldeepkeshwar and others