Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing angle bracket #252

Merged
merged 1 commit into from
Dec 5, 2023
Merged

added missing angle bracket #252

merged 1 commit into from
Dec 5, 2023

Conversation

toolittlecakes
Copy link
Contributor

@toolittlecakes toolittlecakes commented Dec 5, 2023

Context

Graphviz library didn't work correctly because of the bracket disbalance near <table> tag

Summary by CodeRabbit

  • Bug Fixes
    • Corrected an issue in the entity resolution documentation where the HTML table tag was improperly formatted, ensuring the visual representation of entity properties is displayed correctly.

Copy link
Contributor

coderabbitai bot commented Dec 5, 2023

Walkthrough

The update involves a minor but crucial change to the HTML generation function within the entity resolution documentation. A single character, <, has been added to the beginning of an HTML table tag, which could significantly affect the display of entity properties in the generated HTML.

Changes

File Path Change Summary
docs/examples/entity_resolution.md Added < to the beginning of an HTML table tag in generate_html_label function.

🐇✨
To code, a hop, a skip, a leap,
A single < makes a sweep.
In tables' weave, a tiny tweak,
A rabbit's touch, now all's unique. 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between aa62d19 and 54d2613.
Files selected for processing (1)
  • docs/examples/entity_resolution.md (1 hunks)
Additional comments: 1
docs/examples/entity_resolution.md (1)
  • 85-88: The fix for the missing angle bracket in the generate_html_label function appears to be correctly implemented. This should resolve the issue with the Graphviz library's handling of HTML labels.

@jxnl jxnl merged commit af6543c into jxnl:main Dec 5, 2023
4 checks passed
@toolittlecakes toolittlecakes deleted the patch-2 branch December 6, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants