feat: add debugging for retries #283
Conversation
WalkthroughThe update includes enhancements to logging within two functions: Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| logger.exception(f"Retrying, exception: {e}") | ||
| logger.debug(f"Error response: {response}") |
There was a problem hiding this comment.
The added logging statements in the retry_async function are consistent with the PR's objective of enhancing debugging for retry operations. However, the debug log at line 241 may potentially log sensitive information since it logs the entire error response. Consider sanitizing or selectively logging information to avoid potential PII leakage or security issues.
| @@ -282,6 +284,7 @@ | |||
| ) | |||
| except (ValidationError, JSONDecodeError) as e: | |||
| logger.exception(f"Retrying, exception: {e}") | |||
| logger.debug(f"Error response: {response}") | |||
There was a problem hiding this comment.
Similar to the retry_async function, ensure that the debug log at line 287 does not log sensitive information. It's important to sanitize or selectively log information to prevent potential PII leakage or security issues.
Summary by CodeRabbit