Attempt to implement new retires #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Changes requested.
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
| @@ -352,56 +352,79 @@ def retry_sync( | |||
| ): | |||
There was a problem hiding this comment.
The function documentation for retry_sync needs to be updated to reflect the changes in the function's behavior. Specifically, the max_retries parameter can now be an int or a tenacity.Retrying object. Please update the function documentation accordingly.
Also, please ensure that the tests for this function are updated to cover the new functionality.
lukevs
reviewed
Feb 1, 2024
lukevs
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enhances the retry logic in
retry_syncfunction ofinstructor/patch.pyby implementingtenacity.Retryingobject and adding error handling for invalidmax_retriesinput.Key points:
retry_syncfunction ininstructor/patch.py.tenacity.Retryingobject.max_retriesinput.Generated with ❤️ by ellipsis.dev