Test all of our documentation. #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Changes requested.
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
tests/docs/test_docs.py
Outdated
| @@ -1,14 +1,24 @@ | |||
| from math import e | |||
There was a problem hiding this comment.
The import statement 'from math import e' seems unnecessary as 'e' is not used anywhere in the file. Consider removing it to keep the code clean and avoid confusion.
morgante
reviewed
Feb 7, 2024
| @@ -2,5 +2,3 @@ version: 0.0.1 | |||
| patterns: | |||
| - name: github.com/getgrit/python#openai | |||
| level: info | |||
| - name: github.com/getgrit/python#no_skipped_tests | |||
There was a problem hiding this comment.
@jxnl I would love your feedback on why you removed this.
There was a problem hiding this comment.
had to skip some tests that are not passing right now, i thought it was "no skipped tests without reasons"
There was a problem hiding this comment.
Oh, no it forbids all skipped tests right now. Can adjust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just need to run this command and continue tackling some of the problems:
pytest tests/openai/docs --update-examplesSummary:
This PR updates documentation and test files, improving code snippets, adjusting formatting, and updating the output of certain examples.
Key points:
Generated with ❤️ by ellipsis.dev