feat(docs/GPT-4 Vision Model): Add document on extracting tables from images and related functionality #443
Conversation
ellipsis-dev
bot
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
No problems found on commit f17bc98
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with 鉂わ笍 by ellipsis.dev
There was a problem hiding this comment.
Looks good to me! Incremental review on commit c3131f4
Reviewed 12 lines of code across 1 files in 32 second(s).
See details
- Skipped files: 0
- Confidence threshold:
85% - Drafted
1additional comments. - Workflow ID:
wflow_nUKKGGZA71CWJBcR
View 1 draft comments
These comments were drafted by Ellipsis, but were filtered out of the final review. They're included here so you can see our internal thought process and help you configure your ellipsis.yaml.
Drafted 1 comments under confidence threshold
Filtered comment at mkdocs.yml:171
Notes: The PR author has added a new document to the docs/hub directory and updated the mkdocs.yml file to include this new document in the navigation. This is the correct way to add a new document to the documentation. I don't see any issues with this change.
The new document has been correctly added to the mkdocs.yml file. Good job!
Confidence changes required: 0%
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with 鉂わ笍 by ellipsis.dev
|
Skipped PR review on 10dd869 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away. Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository. Generated with 鉂わ笍 by ellipsis.dev |
There was a problem hiding this comment.
Looks good to me! Incremental review on commit ae9615e
Reviewed 186 lines of code across 2 files in 53 second(s).
See details
- Skipped files: 2 (please contact us to request support for these files):
poetry.lock,pyproject.toml - Confidence threshold:
85% - Drafted
1additional comments. - Workflow ID:
wflow_g6KAXWbWK4fATBCi
View 1 draft comments
These comments were drafted by Ellipsis, but were filtered out of the final review. They're included here so you can see our internal thought process and help you configure your ellipsis.yaml.
Drafted 1 comments under confidence threshold
Filtered comment at docs/hub/tables_from_vision.md:35
Notes: The new document
tables_from_vision.mdis added to thedocs/hubdirectory and themkdocs.ymlfile is updated to include this new document in the site navigation. The code in the new document seems to be well-structured and follows the best practices. However, there is a potential issue with themd_to_dffunction. This function is supposed to convert a markdown table into a pandas DataFrame. However, it seems to be assuming that the first column of the table will be used as the index of the DataFrame. This might not always be the case and could lead to incorrect results if the first column is not suitable to be used as an index. It would be better to not make this assumption and let pandas choose the index automatically.
The md_to_df function assumes that the first column of the table will be used as the index of the DataFrame. This might not always be the case and could lead to incorrect results if the first column is not suitable to be used as an index. Consider removing the index_col=1 argument to let pandas choose the index automatically.
pd.read_csv(StringIO(data), sep='|').dropna(axis=1, how='all').iloc[1:].applymap(lambda x: x.strip())
Confidence changes required: 80%
Something look wrong? Tag @ellipsis-dev in a comment, or customize the ellipsis.yaml for this repository.
Generated with 鉂わ笍 by ellipsis.dev
Summary:
This PR adds a new document on extracting tables from images using GPT-4 Vision Model, introduces new classes and functions for handling the extracted data in the new document, and updates the site navigation accordingly.
Key points:
tables_from_vision.mdindocs/hub.MarkdownDataFrame,Table, andMultipleTablesclasses in the new document.extractfunction for interacting with GPT-4 model in the new document.mkdocs.ymlto include the new document in the navigation.Generated with 鉂わ笍 by ellipsis.dev