Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Commit

Permalink
native: Fix font family suffixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jxom committed Sep 4, 2021
1 parent 6e45785 commit ae127a8
Show file tree
Hide file tree
Showing 10 changed files with 28 additions and 28 deletions.
24 changes: 12 additions & 12 deletions native-playground/src/App.js
Expand Up @@ -30,51 +30,51 @@ import ToastPage from './routes/components/Toast';

const weights = {
normal: {
fontFamilySuffix: 'Regular',
fontFamilySuffix: '-Regular',
fontWeight: 'normal',
},
semibold: {
fontFamilySuffix: 'SemiBold',
fontFamilySuffix: '-SemiBold',
fontWeight: 'normal',
},
bold: {
fontFamilySuffix: 'Bold',
fontFamilySuffix: '-Bold',
fontWeight: 'normal',
},
100: {
fontFamilySuffix: 'Thin',
fontFamilySuffix: '-Thin',
fontWeight: 'normal',
},
200: {
fontFamilySuffix: 'ExtraLight',
fontFamilySuffix: '-ExtraLight',
fontWeight: 'normal',
},
300: {
fontFamilySuffix: 'Light',
fontFamilySuffix: '-Light',
fontWeight: 'normal',
},
400: {
fontFamilySuffix: 'Regular',
fontFamilySuffix: '-Regular',
fontWeight: 'normal',
},
500: {
fontFamilySuffix: 'Medium',
fontFamilySuffix: '-Medium',
fontWeight: 'normal',
},
600: {
fontFamilySuffix: 'SemiBold',
fontFamilySuffix: '-SemiBold',
fontWeight: 'normal',
},
700: {
fontFamilySuffix: 'Bold',
fontFamilySuffix: '-Bold',
fontWeight: 'normal',
},
800: {
fontFamilySuffix: 'ExtraBold',
fontFamilySuffix: '-ExtraBold',
fontWeight: 'normal',
},
900: {
fontFamilySuffix: 'Black',
fontFamilySuffix: '-Black',
fontWeight: 'normal',
},
};
Expand Down
2 changes: 1 addition & 1 deletion packages/bumbag-addon-highlighted-code/.gitignore
Expand Up @@ -2,5 +2,5 @@
/lib
/dist
/es
/ts
/ts/bumbag-addon-highlighted-code/src
/HighlightedCode
2 changes: 1 addition & 1 deletion packages/bumbag-addon-markdown/.gitignore
Expand Up @@ -2,5 +2,5 @@
/lib
/dist
/es
/ts
/ts/bumbag-addon-markdown/src
/Markdown
2 changes: 1 addition & 1 deletion packages/bumbag-native-bottom-sheet/.gitignore
@@ -1,5 +1,5 @@
# Automatically generated by ../../scripts/build/utils.js
/lib
/es
/ts
/ts/bumbag-native-bottom-sheet/src
/BottomSheet
2 changes: 1 addition & 1 deletion packages/bumbag-native-picker/.gitignore
@@ -1,6 +1,6 @@
# Automatically generated by ../../scripts/build/utils.js
/lib
/es
/ts
/ts/bumbag-native-picker/src
/PickerIOS
/Picker
2 changes: 1 addition & 1 deletion packages/bumbag-native-toast/.gitignore
@@ -1,5 +1,5 @@
# Automatically generated by ../../scripts/build/utils.js
/lib
/es
/ts
/ts/bumbag-native-toast/src
/Toast
2 changes: 1 addition & 1 deletion packages/bumbag-native/.gitignore
Expand Up @@ -2,7 +2,7 @@
/lib
/dist
/es
/ts
/ts/bumbag-native/src
/utils
/types
/theme
Expand Down
16 changes: 8 additions & 8 deletions packages/bumbag-native/src/theme/fontWeights.ts
Expand Up @@ -6,47 +6,47 @@ export const defaultAndroidFontWeights = {
fontWeight: 'normal',
},
semibold: {
fontFamilySuffix: 'light',
fontFamilySuffix: '-light',
fontWeight: 'bold',
},
bold: {
fontFamilySuffix: '',
fontWeight: 'bold',
},
100: {
fontFamilySuffix: 'thin',
fontFamilySuffix: '-thin',
fontWeight: 'normal',
},
200: {
fontFamilySuffix: 'light',
fontFamilySuffix: '-light',
fontWeight: 'normal',
},
300: {
fontFamilySuffix: 'light',
fontFamilySuffix: '-light',
fontWeight: 'normal',
},
400: {
fontFamilySuffix: '',
fontWeight: 'normal',
},
500: {
fontFamilySuffix: 'light',
fontFamilySuffix: '-light',
fontWeight: 'bold',
},
600: {
fontFamilySuffix: 'medium',
fontFamilySuffix: '-medium',
fontWeight: 'normal',
},
700: {
fontFamilySuffix: '',
fontWeight: 'bold',
},
800: {
fontFamilySuffix: 'medium',
fontFamilySuffix: '-medium',
fontWeight: 'bold',
},
900: {
fontFamilySuffix: 'black',
fontFamilySuffix: '-black',
fontWeight: 'normal',
},
};
Expand Down
2 changes: 1 addition & 1 deletion packages/bumbag-native/src/utils/getCSSFromStyleObject.ts
Expand Up @@ -320,7 +320,7 @@ export function getCSSFromStyleObject(
const fontFamily = font(fontFamilyKey)({ theme });
if (typeof newValue === 'object') {
newStyle = `
font-family: ${fontFamily}${newValue.fontFamilySuffix ? `-${newValue.fontFamilySuffix}` : ''};
font-family: ${fontFamily}${newValue.fontFamilySuffix ? `${newValue.fontFamilySuffix}` : ''};
`;
newValue = newValue.fontWeight;
} else if (fontFamily) {
Expand Down
2 changes: 1 addition & 1 deletion packages/bumbag-native/src/utils/getFontStyles.ts
Expand Up @@ -5,7 +5,7 @@ export function getFontAttributes({ fontFamilyThemeKey, fontWeight: _fontWeight,
let fontFamily = font(fontFamilyThemeKey)({ theme });

if (typeof fontWeight === 'object') {
fontFamily = `${fontFamily}${fontWeight.fontFamilySuffix ? `-${fontWeight.fontFamilySuffix}` : ''}`;
fontFamily = `${fontFamily}${fontWeight.fontFamilySuffix ? `${fontWeight.fontFamilySuffix}` : ''}`;
fontWeight = fontWeight.fontWeight || 'normal';
}

Expand Down

0 comments on commit ae127a8

Please sign in to comment.