Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Bumbag cannot be run without Cookies Enabled #158

Closed
benedictong-localz opened this issue Sep 14, 2021 · 5 comments
Closed

Bumbag cannot be run without Cookies Enabled #158

benedictong-localz opened this issue Sep 14, 2021 · 5 comments
Labels
good first issue Good for newcomers hacktoberfest

Comments

@benedictong-localz
Copy link

Describe the bug

If you are using bumbag in an iframe in incognito mode (which by default disables cookies from third parties) it crashes. I believe this is because one of the dependencies uses localStorage.

To Reproduce

  • Disable cookies
  • go to the bumbag.style website :D

Pasted Graphic 1
@jxom
Copy link
Owner

jxom commented Sep 14, 2021

Can you try disable local storage in this context?

https://www.bumbag.style/docs/color-modes#disabling-local-storage

@jxom
Copy link
Owner

jxom commented Sep 14, 2021

Ideal scenario is that we modify Bumbag to check to see if Storage is available before we use local storage. I am open to PRs for this. Hacktoberfest coming up!

@jxom jxom added good first issue Good for newcomers hacktoberfest labels Sep 14, 2021
@benedictong-localz
Copy link
Author

interesting! That could work, i'll give it a go and report back

@benedictong-localz
Copy link
Author

Worked perfectly! thanks @jxom

@jxom
Copy link
Owner

jxom commented Sep 15, 2021

🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jxom @benedictong-localz