Try to apply mode styles to root html element before body #162
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). bumbag-ui – ./🔍 Inspect: https://vercel.com/jxom/bumbag-ui/JAS1nQBZG2vUWvdx8RXS6Cj5gK5S |
| @@ -4,7 +4,7 @@ import * as React from 'react'; | |||
| const noflash = `(function() { try { | |||
| var mode = localStorage.getItem('bb.mode'); | |||
There was a problem hiding this comment.
I don't have a custom localStoragePrefix set personally, but this code won't work as expected for those who do.
Perhaps that prefix should be saved somewhere so that this little hack can retrieve it here and correctly apply the colour mode?
There was a problem hiding this comment.
Yeah, you are right. I don't think local storage is the best solution here anyway. I think this needs more thinking & a refactor.
|
Bumbag docs seem broken in dark mode. We may need to amend the following to just |
The background colour from custom modes wasn't being correctly applied to pages that had a body smaller than the view height.