green-code-initiative#167 fix(rule): Uses same kind of rule across la…

…nguages
jycr · Apr 12, 2023 · 644e787 · 644e787
1 parent ec6fb2d
commit 644e787
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/php-plugin/src/main/java/fr/greencodeinitiative/php/PhpRuleRepository.java b/php-plugin/src/main/java/fr/greencodeinitiative/php/PhpRuleRepository.java
@@ -38,6 +38,7 @@
 import fr.greencodeinitiative.php.checks.IncrementCheck;
 import fr.greencodeinitiative.php.checks.NoFunctionCallWhenDeclaringForLoop;
 import fr.greencodeinitiative.php.checks.UseOfMethodsForBasicOperations;
+import org.sonar.api.rules.RuleType;
 import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.api.server.rule.RulesDefinitionAnnotationLoader;
 import org.sonar.plugins.php.api.visitors.PHPCustomRuleRepository;
@@ -60,6 +61,7 @@ public void define(Context context) {
     remediationCosts.put(AvoidSQLRequestInLoopCheck.RULE_KEY, "10min");
     remediationCosts.put(AvoidFullSQLRequestCheck.RULE_KEY, "20min");
     repository.rules().forEach(rule -> {
+      rule.setType(RuleType.CODE_SMELL);
       String debt = remediationCosts.get(rule.key());
 
       // TODO DDC : create support to use org.apache.commons.lang.StringUtils

diff --git a/python-plugin/src/main/java/fr/greencodeinitiative/python/PythonRuleRepository.java b/python-plugin/src/main/java/fr/greencodeinitiative/python/PythonRuleRepository.java
@@ -36,6 +36,7 @@
 import fr.greencodeinitiative.python.checks.AvoidTryCatchFinallyCheck;
 import fr.greencodeinitiative.python.checks.NoFunctionCallWhenDeclaringForLoop;
 import org.apache.commons.lang.StringUtils;
+import org.sonar.api.rules.RuleType;
 import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.api.server.rule.RulesDefinitionAnnotationLoader;
 import org.sonar.plugins.python.api.PythonCustomRuleRepository;
@@ -58,6 +59,7 @@ public void define(Context context) {
     remediationCosts.put(AvoidSQLRequestInLoop.RULE_KEY, "10min");
     remediationCosts.put(AvoidFullSQLRequest.RULE_KEY, "20min");
     repository.rules().forEach(rule -> {
+      rule.setType(RuleType.CODE_SMELL);
       String debt = remediationCosts.get(rule.key());
 
       // TODO DDC : create support to use org.apache.commons.lang.StringUtils