Fix saltstack#61243 by checking for GET method before add GET params

jynolen · Nov 18, 2021 · 6fbc067 · 6fbc067
1 parent 71ccdb9
commit 6fbc067
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/changelog/61243.fixed b/changelog/61243.fixed
@@ -0,0 +1 @@
+Add a conditon to be able to add version params only when using GET method
diff --git a/salt/utils/aws.py b/salt/utils/aws.py
@@ -272,9 +272,11 @@ def sig4(
     if location is None:
         location = DEFAULT_LOCATION
 
+    querystring = ""
     params_with_headers = params.copy()
     if product not in ("s3", "ssm"):
-        params_with_headers["Version"] = aws_api_version
+        if method == "GET":
+            params_with_headers["Version"] = aws_api_version
     keys = sorted(params_with_headers.keys())
     values = list(map(params_with_headers.get, keys))
     querystring = urllib.parse.urlencode(list(zip(keys, values))).replace("+", "%20")
@@ -344,8 +346,8 @@ def sig4(
     )
 
     new_headers["Authorization"] = authorization_header
-
-    requesturl = "{}?{}".format(requesturl, querystring)
+    if querystring:
+        requesturl = "{}?{}".format(requesturl, querystring)
     return new_headers, requesturl