implement autogeneration of getter/setter #48

jyoo980 · 2019-10-13T01:13:19Z

Not proud to have written this code, but should probably merge it in for MVP

scveloso

Theres repeated logic for createGetter and createSetter (I feel like there should be a intermediate Object that is a parent of both Class and Interface) but since it's close to film time, this is good!

scveloso · 2019-10-13T02:40:46Z

src/ast/ClassDecl.ts

+
+    private createGetter(name: string, type: string): FuncDecl {
+        let funcGetter: FuncDecl = new FuncDecl();
+        funcGetter.name = "get" + name.charAt(0).toUpperCase() + name.slice(1);


LOL i like it

@uslava77 future work

uslava77 and others added 8 commits October 12, 2019 16:37

Support getter/setter function creation

d84dbd7

merging master into local branch

9183c36

generate getter working

b443d59

finished implementation of getters/setters

5f5478c

merging with master

ced537d

adding sample file

83beda8

adding demo instructions in README.md

925820b

fixing error in simpleProgramClass.txt

1fdc41e

scveloso approved these changes Oct 13, 2019

View reviewed changes

jyoo980 merged commit 71c377f into master Oct 13, 2019

jyoo980 deleted the slava/support-generate branch October 13, 2019 02:43

jyoo980 mentioned this pull request Oct 13, 2019

Generate getters/ setters #42

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement autogeneration of getter/setter #48

implement autogeneration of getter/setter #48

jyoo980 commented Oct 13, 2019

scveloso left a comment

scveloso Oct 13, 2019

jyoo980 Oct 13, 2019

implement autogeneration of getter/setter #48

implement autogeneration of getter/setter #48

Conversation

jyoo980 commented Oct 13, 2019

scveloso left a comment

Choose a reason for hiding this comment

scveloso Oct 13, 2019

Choose a reason for hiding this comment

jyoo980 Oct 13, 2019

Choose a reason for hiding this comment