Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject colon between [closes/fixes/etc.] and ticket references #2

Closed
jzaefferer opened this issue Jan 10, 2014 · 3 comments
Closed

Comments

@jzaefferer
Copy link
Owner

Valid:

Docs: Fix a typo

Closes gh-155

Invalid:

Docs: Fix a typo

Closes: gh-155
@scottgonzalez
Copy link
Contributor

Here's a list that triggers GitHub actions:

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

from https://help.github.com/articles/closing-issues-via-commit-messages

@jzaefferer
Copy link
Owner Author

Something like this might work:

if ( /^(close[sd]?|fix(e(sd)?)?|resolve[sd]?)/i.test( line ) ) { 

To match the keywords, need to check the rest of the line then.

@jzaefferer
Copy link
Owner Author

Released as part of 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants