Validate: Check ticket references

Fixes gh-2
jzaefferer · Jan 14, 2014 · 557d037 · scottgonzalez · Jan 14, 2014 · jzaefferer
1 parent 34c70b3
commit 557d037
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/validate.js b/lib/validate.js
@@ -39,6 +39,13 @@ module.exports = function( message, options ) {
 				line.length + " characters, only " + options.limits.other +
 				" allowed. Was: " + line.substring( 0, 20 ) + "[...]" );
 		}
+		// ticket references
+		if ( /^(close[sd]?|fix(e(sd)?)?|resolve[sd]?)/i.test( line ) ) {
+			if ( !/(Fixes|Closes) (.*#|gh-)[0-9]+/.test( line )) {
+				errors.push( "Invalid ticket reference, must be " +
+					"/(Fixes|Closes) (#|gh-)[0-9]+/, was: " + line );
+			}
+		}
 	});
 
 	return errors;

diff --git a/test.js b/test.js
@@ -14,7 +14,12 @@ var valid = [
 		"\n" +
 		"Long description\n" +
 		"\n" +
-		"Close #xxx"
+		"Closes #123"
+	},
+	{
+		msg: "Component: short message\n" +
+		"\n" +
+		"Closes jquery/jquery-mobile#123"
 	},
 	{
 		msg: "short message",
@@ -59,6 +64,10 @@ var invalid = [
 		msg: "component: bla\n\nline too long beyond 80 chars line too long beyond" +
 			"line too long line too long line too long",
 		expected: [ "Commit message line 3 too long: 91 characters, only 80 allowed. Was: line too long beyond[...]" ]
+	},
+	{
+		msg: "Docs: Fix a typo\n\nCloses: gh-155",
+		expected: [ "Invalid ticket reference, must be /(Fixes|Closes) (#|gh-)[0-9]+/, was: Closes: gh-155" ]
 	}
 ];