-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist component for fixup commits #28
Comments
@mislav any thoughts on this? Am I missing something? |
I'm not sure what are you hinting at with square brackets, but the importance of whitelisting
I have no opinion on the square brackets notation, as I think it represent completely different and unrelated use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#26 suggests allowing "fixup!" as a prefix to whitelist, but that's very specifc to the
--fixup
flag and will reuse the existing commit message. In our current PR workflows, we use something like "[fix]: description of the fixup".Could also whitelist
/\[[^\]]+\]:/
(anything in square brackets), along with "fixup!" and "squash!".The text was updated successfully, but these errors were encountered: