-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate use of Ref
ticket references
#34
Comments
Sounds reasonable. I'm currently heavily focused on finishing jQuery UI 1.12. Maybe someone from the Core team can help this and #33? Add a test, implement it in lib/validate.js. I can find a few minutes for reviewing PRs, tagging and publishing, but the implementation would have to wait a while. |
I created this ticket because I was looking at it, just didn't want to assign it to myself in case I got sidetracked. |
👍 |
I actually disagree with this you don't always want to just ref a ticket what if you want to reference a blog post or some other reason for the change i think ref still makes sense in this case. You can also use this to reference issues from other currently unsupported issue trackers like Jira |
I'd be fine with all these using the |
@dmethvin that would work for me sounds good |
I've reviewed this with @all3fox. We can't think of any usecase where commitplease could correctly point out an issue with a We can reopen with good usecases. |
👍 |
The jQuery ticket reference guidelines allow the use of
Ref
to reference a ticket without closing it. These should be validated as well, since it will impact the efficacy of #33.I used #33 there instead of gh-33 on purpose. 😈
The text was updated successfully, but these errors were encountered: