Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate use of Ref ticket references #34

Closed
dmethvin opened this issue Jan 22, 2015 · 8 comments
Closed

Validate use of Ref ticket references #34

dmethvin opened this issue Jan 22, 2015 · 8 comments

Comments

@dmethvin
Copy link

The jQuery ticket reference guidelines allow the use of Ref to reference a ticket without closing it. These should be validated as well, since it will impact the efficacy of #33.

I used #33 there instead of gh-33 on purpose. 😈

@jzaefferer
Copy link
Owner

Sounds reasonable. I'm currently heavily focused on finishing jQuery UI 1.12. Maybe someone from the Core team can help this and #33? Add a test, implement it in lib/validate.js. I can find a few minutes for reviewing PRs, tagging and publishing, but the implementation would have to wait a while.

@dmethvin
Copy link
Author

I created this ticket because I was looking at it, just didn't want to assign it to myself in case I got sidetracked.

@jzaefferer
Copy link
Owner

👍

@arschmitz
Copy link
Contributor

I actually disagree with this you don't always want to just ref a ticket what if you want to reference a blog post or some other reason for the change i think ref still makes sense in this case.

You can also use this to reference issues from other currently unsupported issue trackers like Jira

@dmethvin
Copy link
Author

dmethvin commented Dec 4, 2015

I'd be fine with all these using the ticketPrefixes @jzaefferer proposed in #33 and one of the prefixes could be http to allow arbitrary links. Would that work for you @arschmitz?

@arschmitz
Copy link
Contributor

@dmethvin that would work for me sounds good

@jzaefferer
Copy link
Owner

I've reviewed this with @all3fox. We can't think of any usecase where commitplease could correctly point out an issue with a Ref line. If someone wants to include Ref undisclosed security bug CVE123, we should let them. Since this line isn't used to close tickets or generate changelogs, it seems like there's nothing to win here.

We can reopen with good usecases.

@arschmitz
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants