2012 Rewrite: v1.1.0pre #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var i, k, minutesOffset, | ||
| m = rES5ts.exec(timestamp); | ||
| if (m) { |
There was a problem hiding this comment.
Could simplify this method my inverting this check, returning NaN, making this a guard clause. Can then remove the indentation on everything below.
New: * New parser, made as public API ($.prettyDate.parse). * Timezones fully supported as supported by ES5 Date.parse and ISO 8601. * Recognition of (+ unit tests) - 1 week - 1 month - # months - 1 year - # years I've taken months and years with a low-end margin (since days in a month/year varies). Also use a 2-week buffer between the date and the 1+ next year. So if something is 1 year and 2 weeks ago, it shows 1 year not 2 years already. * Documentation blocks. * /demo: Add all variations (same as /test). * /demo: Add dynamic language switcher menu Changes: * "isUTC" option no longer needed. ISO 8601 timestamps can contain timestamps themselves (and should!). Previously this was relevant because the lazy parsing implementation removed [TZ] from the string. But now that this is taken into consideration, it will be more accurate. I considered keeping it, but couldn't make it work reliably. It has to be in the timestamp itself for it to be relevant. * Removed .fromUTC(). * Converted line endings to Unix (git-diff ^M warnings). * Rename /localization and files to match jquery-ui convention. New directory: /i18n The filenames were mostly already there, renamed: - 'jquery-prettydate-fr.js' - 'jquery-prettydate-lv.js' * Added new lines at EOFs. * Update upstream libs. * Update demo markup. * Update unit tests. * Update Dutch translation (i18n.nl). * Bump version number to next +'pre'. Issues: * Fix indentation and missing semicolons in various places * Fix "same has been deprecated since 2009 (e88049a0), use assert.deepEqual instead". * Passed JSHint. * Closes jzaefferer#2: Bad results when server and client timezones differ. * Closes jzaefferer#6: "1 weeks" -> "1 week". * Closes jzaefferer#8: Adding support for months and years. Libs: * curl 'http://code.jquery.com/jquery.js' > libs/jquery.js * git submodule add git://github.com/jquery/qunit.git libs/jquery.qunit
|
Landed! Updated the german translation to include the new properties in abbd72b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message