Change element.value references to use jQuery.val() method #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. This pull request breaks current tests. Namely string replace() is called on val() which breaks with a non-string value (such as multi-selects). Could you add more checks to the val calls and make sure the tests pass? |
mlynch
added a commit
to mlynch/jquery-validation
that referenced
this pull request
Mar 28, 2012
|
d963540 makes this pass our tests, but I'm not sure that calling Array.join on the value of a multiple="true" select is correct. I'd like some feedback on this. |
Closed
mlynch
added a commit
to mlynch/jquery-validation
that referenced
this pull request
Mar 28, 2012
|
excellent - i'd almost forgotten about this. thanks for the help. |
mlynch
added a commit
to mlynch/jquery-validation
that referenced
this pull request
Mar 30, 2012
… fixed some methods that relied on string values. Fix for jquery-validation#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jörn, per our email discussion:
This change standardizes the element value lookups, thereby allowing users to override the standard jQuery val() method for any needed preprocessing of element values.