Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic access token refreshment when expired #1

Open
jzheng2017 opened this issue Dec 11, 2020 · 4 comments
Open

Add automatic access token refreshment when expired #1

jzheng2017 opened this issue Dec 11, 2020 · 4 comments
Labels
api An issue directly related to the public api of the library authorization An issue related to the authorization enhancement New feature or request

Comments

@jzheng2017
Copy link
Owner

jzheng2017 commented Dec 11, 2020

Is your feature request related to a problem? Please describe.
Currently when the access token expires the API can no longer make any request to the Spotify Web API. There is no system in place that detects whether the access token has expired and refreshes the token when necessary.

The feature request is to implement a system that will refresh the access token automatically when expired using the already existing AuthorizationRefreshToken.

Describe the solution you'd like
The system should be able to detect when the token has expired. When it has detected that the token has expired it will make a request to Spotify Authorization API for a new access token. When the new access token has been obtained it should update all services that use that token to make requests.

Describe alternatives you've considered
None at the moment.

Additional context
This feature should be implemented in SpotifyApi, or somewhere else if it is more fitting but should be well substantiated why it is done that way.

@jzheng2017 jzheng2017 added enhancement New feature or request authorization An issue related to the authorization api An issue directly related to the public api of the library labels Dec 11, 2020
@razorahul
Copy link

razorahul commented Nov 6, 2023

Attempting issue #1

@jzheng2017
Copy link
Owner Author

Attempting issue #1

Any update on the progress of this issue?

@razorahul
Copy link

@jzheng2017 Will update in next 2 days.

@jzheng2017
Copy link
Owner Author

jzheng2017 commented Dec 3, 2023

@jzheng2017 Will update in next 2 days.

I will remove you as assignee for now. If you have more update on the progress I will reassign you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api An issue directly related to the public api of the library authorization An issue related to the authorization enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants