Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Docker Image #49

Closed
anuragagarwal561994 opened this issue Jul 26, 2023 · 3 comments · Fixed by #50
Closed

Support for Docker Image #49

anuragagarwal561994 opened this issue Jul 26, 2023 · 3 comments · Fixed by #50

Comments

@anuragagarwal561994
Copy link
Contributor

We can add support for docker image so that this project is deployable and usable easily for the end user in any environment.

@jzillmann
Copy link
Owner

How is this helpful ?
Where do you generate the reports ? On the docker instance ?

@anuragagarwal561994
Copy link
Contributor Author

anuragagarwal561994 commented Jul 27, 2023

So for now, this can allow the user to just self host jmh-visualizer.

But the scope of the visualizer can be further extended after this to make it more worth installing via docker. For example one can mention a directory to find the reports (say data). The UI can display the directory structure and display reports in the UI.

This can then become self sufficient where the benchmarks can be run in docker environment and results are published in a shared volume. jmh-visualizer can then read the directory structure of this shared volume and help the user visualise the data.

As of now I am using similar setup in a docker-compose.yaml way where my benchmark runs and puts the result in a volume. Now that volume is shared the visualizer container. Since visualizer container has nginx to host the UI, I can access the report at lets say: http://localhost?source=http://localhost/reports.json and this is pretty seamless.

A little bit unrelated, but I feel that this project is very simple and does just what's needed very nicely. A nice to have feature keeping in mind the above extensibility would be to expose it as a react component, that would allow users to integrate it at more places and even in their UI applications. One use case I can think of here is to fetch the reports from mongo and use the React Component in my App to display the reports.

@jzillmann
Copy link
Owner

Thanks for the answer and sorry for the delay in response... It is merged now.

Regarding the React component... Currently don't do active development of the project.
If you want to implement this, feel free. If it's not too crazy I will merge it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants