Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-upload a file that is in someone's trash #7

Closed
shenriod opened this issue Jan 16, 2018 · 6 comments
Closed

Re-upload a file that is in someone's trash #7

shenriod opened this issue Jan 16, 2018 · 6 comments

Comments

@shenriod
Copy link
Contributor

I am translating the help page in French but one behavior is not clear to me:

If User A uploads a document and then moves it to trash (but does NOT delete it permanently), will user B be able to re-upload the same document?

If not, what information will user B receive, in order to identify in whose trash it is? It can otherwise be very frustrating for user B and it will also be a hassle for the librarian to identify where the "1st version" of the file is hiding

Can you clarify the behavior so that I can accordingly make it clear in the help page?

Thanks!

@avvertix
Copy link
Contributor

If User A uploads a document and then moves it to trash (but does NOT delete it permanently), will user B be able to re-upload the same document?

The current behavior for document upload is to verify the existence of the exact same version (based on the content hash). The trash plays also a role as it is considered a valid location (trashed files can be restored and therefore needs to still respect the uniqueness policy), therefore it is indicated that the file already exists with the name of the file or the title of the document. In general cases the title of the document is provided as the File is described by a Document Descriptor. In some rare cases only the File original name will be outputted in the already existing message

This is different for video uploads using the video uploader (the new experimental upload mechanism): with this tool the upload of the same file more than 1 time is allowed.

The rationale is to that verify that a video has already been upload is difficult (two videos might be the same, but at different resolution) and is not possible until the whole file is uploaded. If we let upload the whole, e.g. 1GB video, and then delete it because it already exists it will generate a waste of bandwidth and user time.

Please be aware that with the video uploader ability to upload multiple times the same file duplication in search results might occur.

@shenriod
Copy link
Contributor Author

shenriod commented Jan 17, 2018 via email

@avvertix
Copy link
Contributor

Can user B know in whose's Trash the first version is?

No, currently not

I am just worried that user B will only see that he cannot upload a doc,
... f I upload a doc to my personal collection, user B won't be able to upload again the same doc, but he also cannot see my personal collection.

This is what currently happens

Do you see this problem as well or did I misunderstand something?

I actually see the problem, but the overall "Already exists check" is a complex feature. Exposing that a file is in someone's trash is a privacy leaking, like stating that is personal to some user. On the other side the users don't want to see duplication in search results (with duplications I mean the same document listed twice). The compromise was to limit the upload of a document that already exists, but is clearly more acceptable in a shared scenario, where documents are mostly shared accross all users.

@shenriod
Copy link
Contributor Author

shenriod commented Jan 17, 2018 via email

@avvertix
Copy link
Contributor

yep, a general question here should be resolved: "is better to have duplication of same files or to stick with blocking what is already existent?".

Maybe: when a doc is in the trash, it is no longer considered as "in the system", so that user B can upload it again. And if user A tries to get the doc out of his trash, only then the system will say "this doc already exists here .... ." I think that would be much more transparent .

I think this will not solve the point, as move the problem on the restore of the file, where the same generic already exists message is used in case a document is in someone's personal area (again the privacy problem, which I think it should be respected)

@shenriod
Copy link
Contributor Author

I think this will not solve the point, as move the problem on the restore of the file, where the same generic already exists message is used in case a document is in someone's personal area (again the privacy problem, which I think it should be respected)

Right... this needs some more thinking... I will close the issue for now and we can brainstorm later, in the frame of the global roadmap of the System

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants