Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow duplicated documents #108

Merged
merged 46 commits into from Jul 17, 2018
Merged

Allow duplicated documents #108

merged 46 commits into from Jul 17, 2018

Conversation

avvertix
Copy link
Contributor

@avvertix avvertix commented Jul 11, 2018 •
edited

What does this PR do?

  • Allow to upload the same document multiple times
  • Show and highlight the duplicate
  • Allow to remove a duplicate by deleting the new upload in favor of the already existing file
  • Send a mail notification with the duplicates after the user upload documents
  • Add new URLs for preview and download based on the document UUID (the old /klink URLs are now deprecated)

Related issues

Fixes #40

Review checklist

  • Are unit tests required? Yes, added
  • Are Documentation changes needed? Yes, done

Before merging

  • Is history cleaned up? (or can be squashed on merge?)

@avvertix avvertix added this to the 0.22 milestone Jul 11, 2018
@shenriod
Copy link
Contributor

Add new URLs for preview and download based on the document UUID (the old /klink URLs are now deprecated)

Does it mean that all previously shared links will be invalid? Or will there be a retro-compatibility?

@avvertix
Copy link
Contributor Author

avvertix commented Jul 12, 2018 •
edited

Add new URLs for preview and download based on the document UUID (the old /klink URLs are now deprecated)

Does it mean that all previously shared links will be invalid? Or will there be a retro-compatibility?

The old URLs will still work and by default the browser will be redirected to the new URL format.

@avvertix
Moved KlinkApiController tests to DocumentPreviewControllerTest
7dde2b0
@avvertix
Add macro to http request for checking if comes from a K-Search
8f94a0d
@avvertix
Commenting the hash uniqueness check
2138c9f
@avvertix
Clean import of Carbon
1038e0e
@avvertix
Document preview
22c30df
@avvertix
Change K-Link API controller to redirect to new preview and download …
9240372 
…routes
@avvertix
Use the newly defined routes
7a9fe81
@avvertix
Preliminary thumbnail and download controllers
ec92a42
@avvertix
Uniformed file download
fcc6e6a
@avvertix
[ci skip[ Preliminary controllers for thumbnail and download action
f5a89b7
@avvertix
Download and version tests
f609bf7
@avvertix
Thumbnail controller
838663b
@avvertix
Code style
07942c5
@avvertix
Fix side effect of a change
c274103
@avvertix
Make document and thumbnail url optional and generated on demand
06dfc83
@avvertix
Clean already exists check
1238fdc
@avvertix
Rename /d/ and /t/ routes according to latest discussion
e4fdef8
@avvertix
Duplicate document and event
1e60139
@avvertix
Base mail notification of the duplicates
1356e6b
@avvertix
Code style
06ffd7e
@avvertix
Presentation of the duplication details
eb0a3f0
@avvertix
Fix usage of wrong database trait
a974159
@avvertix
Duplicate document message
e1dada2
@avvertix
Remove middleware only from upload test
e596e65
@avvertix
Protect against null $errors
7ef7172
@avvertix
Fix edit page test
76ecca9
@avvertix
Code style
38ea3ce
avvertix and others added 17 commits July 16, 2018 12:17
@avvertix
Hide empty collection message on duplicate if no collections are atta…
eff94f8 
…ched
@avvertix
Clear database trait.
fd1b74f 
Truncate the table contents before executing a unit test
@avvertix
Add group_closure table to ClearDatabase trait
39ae285
@avvertix
Ensure clean database
8a26ade
@avvertix
Duplicate resolution
06a4b5a
@avvertix
Improve duplication notification mail content
2791bf1
@avvertix
Some logging
35e2ecd
@avvertix
Switching to a dev branch of the k-search client to see if indexing e…
0390b6a 
…rrors are resolved
@avvertix
trigger reindex method
b3ca206
@avvertix
changed the check for descriptor equality
f82e35a
@salaidin @avvertix
added duplicates
7846864
@salaidin @avvertix
improved RUS text duplicates
f26967b
@avvertix
Fix duplicate in collection message
6ff4b93
@avvertix
Add documentation about documents and duplicates
a30dd1e
@avvertix
fix js callback
090b7ea
@avvertix
Protection over reindex trigger error
6e2fad8
@avvertix
Code style
09d41e7
@avvertix avvertix force-pushed the 555-workflow-duplicated-documents branch from ab8ecdd to 09d41e7 Compare July 16, 2018 10:18
@avvertix avvertix merged commit d814c09 into master Jul 17, 2018
@avvertix avvertix deleted the 555-workflow-duplicated-documents branch July 17, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avvertix @shenriod @salaidin