Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullsafety support #97

Closed
Tracked by #1
aliyazdi75 opened this issue Nov 29, 2020 · 15 comments
Closed
Tracked by #1

Nullsafety support #97

aliyazdi75 opened this issue Nov 29, 2020 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@aliyazdi75
Copy link

flutter pub get:

Because every version of flutter_localizations from sdk depends on intl 0.17.0-nullsafety.2 and dart_json_mapper 1.7.2 depends on intl ^0.16.1, flutter_localizations from sdk is incompatible with dart_json_mapper 1.7.2.
And because no versions of dart_json_mapper match >1.7.2 <2.0.0, flutter_localizations from sdk is incompatible with dart_json_mapper ^1.7.2.
So, because  depends on both dart_json_mapper ^1.7.2 and flutter_localizations any from sdk, version solving failed.
@aliyazdi75
Copy link
Author

It can be fixed by adding:

dependency_overrides:
  intl: ^0.17.0-nullsafety.2

@k-paxian k-paxian self-assigned this Nov 29, 2020
@k-paxian k-paxian added the enhancement New feature or request label Nov 29, 2020
@k-paxian k-paxian changed the title Version solving failed Nullsafety support Nov 29, 2020
@k-paxian
Copy link
Owner

image
At the moment I'm doing exactly that.
reflectable package is not migrated yet, as soon it'll happens I'll proceed with the migration

k-paxian added a commit that referenced this issue Dec 3, 2020
@mit-mit
Copy link

mit-mit commented Dec 4, 2020

Null safety support in reflectable is tracked in google/reflectable.dart#229

@jiechic
Copy link

jiechic commented Mar 5, 2021

image
At the moment I'm doing exactly that.
reflectable package is not migrated yet, as soon it'll happens I'll proceed with the migration

it is update reflectable 3.0.0-nullsafety.1

@k-paxian
Copy link
Owner

k-paxian commented Mar 5, 2021

It should be stable, 3.0.0 otherwise it's not ready. At this moment it's only a preview of partial migration.

@k-paxian k-paxian pinned this issue Mar 9, 2021
@cedvdb
Copy link

cedvdb commented Mar 16, 2021

stable has been released, v3.0.0 although I don't see the null-safety label the PR says it's for null safety google/reflectable.dart#237

Prepare a release as 3.0.0 (not 3.0.0-nullsafety.X), that is, a stable release with null safety support.

k-paxian added a commit that referenced this issue Mar 17, 2021
* #97, null safety support
k-paxian added a commit that referenced this issue Mar 17, 2021
* #97, null safety support
k-paxian added a commit that referenced this issue Mar 17, 2021
* #97, null safety support
@k-paxian
Copy link
Owner

Mapper has been migrated to null safety 🥇, but..., due to this issue, pub.dev doesn't recognize that yet 😞 we are still waiting for the wonder.

@mapleafgo
Copy link

Hope to provide nullsafety support for dart_json_mapper_mobx

@k-paxian
Copy link
Owner

@mapleafgo ok, I thought no one is using it really

@mapleafgo
Copy link

@mapleafgo ok, I thought no one is using it really

It's a very useful tool.

@buzzware
Copy link

Still waiting for this, even though https://pub.dev/packages/reflectable/changelog says
"3.0.0 Support null safety in a stable version of reflectable."
This is the last thing holding up my app from null safety.

@k-paxian
Copy link
Owner

@buzzware According to this issue all the blame could be addressed towards maintainers of build_runner_core which is Google 😄

@buzzware
Copy link

@buzzware According to this issue all the blame could be addressed towards maintainers of build_runner_core which is Google 😄

OK, thanks, I'll draw their attention to it

@k-paxian
Copy link
Owner

k-paxian commented May 6, 2021

image

@k-paxian k-paxian closed this as completed May 6, 2021
@k-paxian k-paxian unpinned this issue May 6, 2021
@buzzware
Copy link

buzzware commented May 7, 2021

Yay! Thanks to all involved. I just got back to this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants