Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] 추가될 데이터 input들 변경하기 #101

Merged
merged 4 commits into from
Oct 10, 2021
Merged

[Design] 추가될 데이터 input들 변경하기 #101

merged 4 commits into from
Oct 10, 2021

Conversation

YuuRiLee
Copy link
Contributor

@YuuRiLee YuuRiLee commented Sep 4, 2021 •
edited
Loading

PR 제안 사유

Resolve #98

주요 변경 기록

  • SnakeToCamelCase 타입 추가
  • 추가될 데이터 input들 변경하기 (난이도, 뜨개 기법, 도안 한 줄 소개 추가, 판매 가격 삭제)

Code review

Code review 에서 중점적으로 봐야하는 부분

Design review

Design review 에서 중점적으로 봐야하는 부분 / 스크린샷

스크린샷 2021-09-04 오후 4 34 28

기타 질문 및 특이 사항

@YuuRiLee YuuRiLee added Feat 새로운 기능과 관련된 작업 Design 디자인과 관련된 작업 labels Sep 4, 2021
@YuuRiLee YuuRiLee self-assigned this Sep 4, 2021
zoripong
zoripong approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@zoripong zoripong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

점점 ts 장인이 되어가시는구먼유..

src/utils/types.ts Show resolved Hide resolved
src/pages/CreateDesign/Detail/index.tsx Outdated Show resolved Hide resolved
Base automatically changed from request-refactor to main September 17, 2021 14:46
@YuuRiLee
Copy link
Contributor Author

YuuRiLee commented Sep 18, 2021 •
edited
Loading

@jiyaaany 해당 커밋부터 봐주세유

@YuuRiLee YuuRiLee changed the base branch from main to sprint-2-1 September 18, 2021 05:38
@YuuRiLee YuuRiLee merged commit 4a84472 into sprint-2-1 Oct 10, 2021
@YuuRiLee YuuRiLee deleted the design-input-change branch October 10, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoripong zoripong zoripong approved these changes

@jiyaaany jiyaaany jiyaaany approved these changes

Assignees

@YuuRiLee YuuRiLee

Labels
Design 디자인과 관련된 작업 Feat 새로운 기능과 관련된 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 추가될 데이터 input들 변경하기
3 participants
@YuuRiLee @zoripong @jiyaaany