Fixing CI issue

k-rudy · Apr 23, 2014 · e9cdb98 · e9cdb98
1 parent 3eddb29
commit e9cdb98
Show file tree

Hide file tree

Showing 3 changed files with 68 additions and 75 deletions.
diff --git a/config/application.yml.example b/config/application.yml.example
@@ -2,55 +2,54 @@ sources:
   ru:
     url: http://google.com
     mappings:
-      mappings:
-        gn: ge
-        lv: le
-        nm: nu
-        dt: de
-        jgs: jud
-        1sm: 1ki
-        2sm: 2ki
-        1kgs: 3ki
-        2kgs: 4ki
-        1chr: 1ch
-        2chr: 2ch
-        neh: ne
-        tb: tob
-        est: es
-        1mc: 1ma
-        2mc: 2ma
-        jb: job
-        prv: pr
-        eccl: ec
-        sg: so
-        is: isa
-        lam: la
-        ez: ezr
-        dn: da
-        hos: ho
-        jl: joe
-        mi: mic
-        hb: hab
-        zep: sof
-        hg: hag
-        mk: mr
-        lk: lu
-        jn: joh
-        acts: ac
-        rom: ro
-        1cor: 1co
-        2cor: 2co
-        gal: ga
-        phil: php
-        1thes: 1th
-        2thes: 2th
-        1tm: 1ti
-        2tm: 2ti
-        ti: tit
-        phlm: phm
-        1pt: 1pe
-        2pt: 2pe
-        1jn: 1jo
-        2jn: 2jo
-        3jn: 3jo
-        rev: re
+      gn: ge
+      lv: le
+      nm: nu
+      dt: de
+      jgs: jud
+      1sm: 1ki
+      2sm: 2ki
+      1kgs: 3ki
+      2kgs: 4ki
+      1chr: 1ch
+      2chr: 2ch
+      neh: ne
+      tb: tob
+      est: es
+      1mc: 1ma
+      2mc: 2ma
+      jb: job
+      prv: pr
+      eccl: ec
+      sg: so
+      is: isa
+      lam: la
+      ez: ezr
+      dn: da
+      hos: ho
+      jl: joe
+      mi: mic
+      hb: hab
+      zep: sof
+      hg: hag
+      mk: mr
+      lk: lu
+      jn: joh
+      acts: ac
+      rom: ro
+      1cor: 1co
+      2cor: 2co
+      gal: ga
+      phil: php
+      1thes: 1th
+      2thes: 2th
+      1tm: 1ti
+      2tm: 2ti
+      ti: tit
+      phlm: phm
+      1pt: 1pe
+      2pt: 2pe
+      1jn: 1jo
+      2jn: 2jo
+      3jn: 3jo
+      rev: re
diff --git a/spec/libs/bible/scrapers/base_spec.rb b/spec/libs/bible/scrapers/base_spec.rb
@@ -140,36 +140,44 @@
   end
 
   describe '#book_mapping' do
+
+    before { subject.stub(translation: 'ru') }
 
     context 'when there is no mapping defined' do
 
-      before do 
-        book.stub(title: 'Le')
-        subject.stub(translation: 'ru')
-      end
+      before { book.stub(title: 'Le') }
 
       it 'returns downcased book title' do
         expect(subject.send(:book_mapping, book)).to eq('le')
       end
     end
+
+    context 'when there is a mapping for the book' do
+
+      before { book.stub(title: 'Gn') }
+
+      it 'returns mapping value' do
+        expect(subject.send(:book_mapping, book)).to eq('ge')
+      end
+    end
   end
 
   describe '#missing_mappings' do
 
-    let(:genesis) { build(:book, title: 'Zx') } 
+    let(:genesis) { build(:book, title: 'Gn') } 
     let(:leviticus) { build(:book, title: 'Le') } 
-    let(:numbers) { build(:book, title: 'Nd') } 
+    let(:numbers) { build(:book, title: 'Nm') } 
 
     before do
       subject.stub(translation: 'ru')
-      subject.stub(:scrape_verse).with('zx', 1, 2).and_return('Genesis')
+      subject.stub(:scrape_verse).with('ge', 1, 2).and_return('Genesis')
       subject.stub(:scrape_verse).with('le', 1, 2).and_return(nil) 
-      subject.stub(:scrape_verse).with('nd', 1, 2).and_raise(OpenURI::HTTPError.new('error', nil))
+      subject.stub(:scrape_verse).with('nu', 1, 2).and_raise(OpenURI::HTTPError.new('error', nil))
       Bible::Book.stub(all: [ genesis, leviticus, numbers ])   
     end
 
     it 'returns the list of books that need mapping' do
-      expect(subject.missing_mappings).to eq([ 'Le', 'Nd' ])
+      expect(subject.missing_mappings).to eq([ 'Le', 'Nm' ])
     end
   end
 

diff --git a/spec/libs/bible/scrapers/ru_spec.rb b/spec/libs/bible/scrapers/ru_spec.rb
@@ -4,20 +4,6 @@
 
   subject { Bible::Scrapers::Ru }
 
-  describe '#book_mapping' do
-
-    let(:book) { double('book', chapters_count: 1) }
-
-    context 'when there is a mapping for the book' do
-
-      before { book.stub(title: 'Gn') }
-
-      it 'returns mapping value' do
-        expect(subject.send(:book_mapping, book)).to eq('ge')
-      end
-    end
-  end
-
   describe '#scrape_verse' do
 
     context 'Offline test' do