Support --enable-mutlithread for MinGW build #54
Merged
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to check pthread availability for MinGW build because Windows provides thread API by default. Note that we need to regenerate configure.
|
Thank you and sorry for the very late response. Merged. |
|
Thanks. Could you update |
|
I will update it later. |
|
Thanks. |
k-takata
added a commit
that referenced
this pull request
Oct 7, 2016
Update by using autoreconf-2.69. Related: #54
|
Updated. |
kou
added a commit
to groonga/groonga
that referenced
this pull request
Oct 8, 2016
It includes MinGW + thread fix by k-takata/Onigmo#54.
|
Thanks! |
|
Hmm, strange. Why coveralls report this on a two-years-old PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to check pthread availability for MinGW build because
Windows provides thread API by default.
Note that we need to regenerate
configure.