Fix chdir() may crash

This crashes. ```vim let pwd = chdir('non-existing-dir') call chdir(pwd) ```
k-takata · Jan 30, 2020 · 63b3972 · 63b3972
1 parent 92be6e3
commit 63b3972
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/ex_docmd.c b/src/ex_docmd.c
@@ -6572,6 +6572,8 @@ changedir_func(
     int		dir_differs;
     int		retval = FALSE;
 
+    if (new_dir == NULL)
+	return FALSE;
     if (allbuf_locked())
 	return FALSE;
 

diff --git a/src/testdir/test_cd.vim b/src/testdir/test_cd.vim
@@ -101,6 +101,8 @@ func Test_chdir_func()
   call assert_fails("call chdir('dir-abcd')", 'E472:')
   silent! let d = chdir("dir_abcd")
   call assert_equal("", d)
+  " Should not crash
+  call chdir(d)
 
   only | tabonly
   call chdir(topdir)