implement arp responder #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
Signed-off-by: Andrew Sy Kim <kiman@vmware.com> Co-authored-by: Zaalouk, Adel <adel.zalok.89@gmail.com>
zanetworker
reviewed
Jun 3, 2019
| tableLocalARP = 100 | ||
|
|
||
| // all pods have a fixed mac addr | ||
| podMacAddr = "aa:bb:cc:dd:ee:ff" |
There was a problem hiding this comment.
this is defined twice (here and veth.go), would a common home for it make sense?
There was a problem hiding this comment.
A single package/file for 1 const seemed overkill but agree we should revisit this soon
|
Agreed on both comments. Let's see how this pans out and revisit this code, definitely needs some clean up. Created #11 to follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Sy Kim kiman@vmware.com
Co-authored-by: Zaalouk, Adel adel.zalok.89@gmail.com