fix paths with trailing separator #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-yle
added a commit
that referenced
this pull request
Dec 13, 2022
|
Weird... Thanks for the PR. I've added your example pdf as a test case, which is currently passing, even without this PR. I can confirm the warning disappears as of this PR. |
|
With the new 2.1.1 release it's working fine. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am sorry because my last fix in #194 was not enough, I checked with the new 2.1.0 release and the bug is still present, the fact is that pdfjs doesn't use
path.jointo build the paths, so the trailing path separator at the end has to be added manually.