Skip to content

Commit

Permalink
make the windowsHide property configurable
Browse files Browse the repository at this point in the history
  • Loading branch information
k-yle committed Oct 26, 2021
1 parent 33743d5 commit 28e7f16
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## 1.6.0 (2021-10-27)

- feat: make the [`windowsHide`](https://nodejs.org/api/child_process.html) property configurable (defaults to `true`)
- chore: run tests on node17, stop testing on node10

## 1.5.1 (2021-07-27)

- fix: fix bug with RTSP transport option (#89)
Expand Down
5 changes: 3 additions & 2 deletions index.js
Expand Up @@ -11,6 +11,7 @@ const { version } = require('./package.json');
* additionalFlags?: string[];
* verbose?: boolean;
* transport?: 'udp' | 'tcp' | 'udp_multicast' | 'http';
* windowsHide?: boolean;
* }} Options
*
* @typedef {import("express").Application} Application
Expand All @@ -24,7 +25,7 @@ class InboundStreamWrapper {
}

/** @param {Options} props */
start({ url, additionalFlags = [], transport }) {
start({ url, additionalFlags = [], transport, windowsHide = true }) {
if (this.verbose) console.log('[rtsp-relay] Creating brand new stream');

// validate config
Expand Down Expand Up @@ -52,7 +53,7 @@ class InboundStreamWrapper {
...additionalFlags,
'-',
],
{ detached: false },
{ detached: false, windowsHide },
);
this.stream.stderr.on('data', () => {});
this.stream.stderr.on('error', (e) => console.log('err:error', e));
Expand Down
2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "rtsp-relay",
"version": "1.5.1",
"version": "1.6.0",
"author": "Kyle Hensel",
"license": "MIT",
"description": "馃摻 Relay an RTSP stream through an existing express.js server",
Expand Down

0 comments on commit 28e7f16

Please sign in to comment.