Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise haml error when compile check #189

Merged
merged 1 commit into from Feb 3, 2022
Merged

Raise haml error when compile check #189

merged 1 commit into from Feb 3, 2022

Conversation

dlwr
Copy link
Contributor

@dlwr dlwr commented Feb 3, 2022

( This Pull Request has been continued from #188 (comment) )

raise the error in Hamlit::Parser when hamlit compile -c to check haml error.

$ cat invalid-haml-syntax.haml
%h1
  title
%div
 %span

Before this Pull Request

$ bundle exec exe/hamlit compile -c invalid-haml-syntax.haml
Syntax OK
$ echo $?
0

After this Pull Request

$ bundle exec exe/hamlit compile -c invalid-haml-syntax.haml
bundler: failed to load command: exe/hamlit (exe/hamlit)
(haml):4: Inconsistent indentation: 1 space used for indentation, but the rest of the document was indented using 2 spaces. (Hamlit::HamlSyntaxError)
...

$ echo $?
1

@dlwr dlwr mentioned this pull request Feb 3, 2022
Copy link
Owner

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k0kubun k0kubun merged commit 03c5041 into k0kubun:master Feb 3, 2022
@dlwr dlwr deleted the raise-haml-error-when-compile-check branch February 3, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants